Skip to content

chore: bump narwhals>=2.4.0#3970

Merged
dangotbanned merged 10 commits intomainfrom
bump-narwhals-2.x
Mar 4, 2026
Merged

chore: bump narwhals>=2.4.0#3970
dangotbanned merged 10 commits intomainfrom
bump-narwhals-2.x

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Mar 4, 2026 •
edited
Loading

@dangotbanned
ci(uv): bump narwhals>=2.4.0
ed8ded9 
Closes #3960

narwhals-dev/narwhals#3013
narwhals-dev/narwhals#2944
narwhals-dev/narwhals#2971
narwhals-dev/narwhals#3016
@dangotbanned
fix(typing): Resolve datasets/narwhals issues
966f6ae 
Fixes narwhals-dev/narwhals#3013
@dangotbanned
refactor(typing): Omit TypeVar w/ default
dfa695f
@dangotbanned
chore(typing): Remove fixed cast
f932506 
Resolved in narwhals-dev/narwhals#2022
@dangotbanned
chore(typing): Temp ignore pyright
e2cb9cc 
I think this is a `polars` bug, since `pyright` thinks `assert_frame_equal` doesn't accept arguments
That definition has some decorators, which might be confusing it
https://docs.pola.rs/api/python/stable/reference/api/polars.testing.assert_frame_equal.html
@dangotbanned
fix(typing): Use the exported symbol name
65f8f8d 
Should respect the boundaries I set myself 😅
narwhals-dev/narwhals#3086
@dangotbanned dangotbanned added maintenance dependencies Pull requests that update a dependency file typing Related to static typing/type hints python:uv Pull requests that update python:uv code labels Mar 4, 2026
dangotbanned
dangotbanned commented Mar 4, 2026
View reviewed changes
dangotbanned added a commit that referenced this pull request Mar 4, 2026
@dangotbanned
ci(uv): Remove polars<1.38 pin
b815efb 
narwhals-dev/narwhals#3450
https://pypi.org/project/polars/1.38.0/
#3970 (comment)
pola-rs/polars#26270
pola-rs/polars#25984
@dangotbanned dangotbanned mentioned this pull request Mar 4, 2026
Merged
dangotbanned
dangotbanned commented Mar 4, 2026
View reviewed changes
@dangotbanned dangotbanned marked this pull request as ready for review March 4, 2026 16:22
@dangotbanned dangotbanned mentioned this pull request Mar 4, 2026
Closed
3 tasks
@dangotbanned dangotbanned linked an issue Mar 4, 2026 that may be closed by this pull request
Re-align altair internal typing narwhals-dev/narwhals#3013
Closed
3 tasks
@mattijn
Copy link
Copy Markdown
Contributor

mattijn commented Mar 4, 2026

Great work @dangotbanned! Out of curiosity, if we move to narwhals v2+, would it make sense to also switch to narwhals.stable.v2? Not suggesting we do it here, just wondering.

@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Mar 4, 2026

Great work @dangotbanned!

Thanks @mattijn

Out of curiosity, if we move to narwhals v2+, would it make sense to also switch to narwhals.stable.v2?

Yeah definitely!
There is some ruff config we need to update to v2, along with the actual imports

Not suggesting we do it here, just wondering.

Yeah agreed, should definitely be it's own PR - but one that I'd welcome 😊

@dangotbanned dangotbanned merged commit 9ba3704 into main Mar 4, 2026
26 checks passed
@dangotbanned dangotbanned deleted the bump-narwhals-2.x branch March 4, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file maintenance python:uv Pull requests that update python:uv code typing Related to static typing/type hints

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Narwhals typing breakage after lock file update (narwhals 2.2 / 2.9) Re-align altair internal typing

2 participants

@dangotbanned @mattijn