Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 1, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

  • Update minimum Python version to 3.10, in line with upstream
  • Replace black and isort with ruff
  • Apply formatting changes by ruff for the new Python version
  • Update dev packages to match vLLM upstream

FIX #54

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@DarkLight1337 DarkLight1337 changed the title [Chore] Bump dependencies to be compatible with upstream v0.11.2 [Chore] Bump Python version and apply formatting change Dec 1, 2025
@DarkLight1337 DarkLight1337 changed the title [Chore] Bump Python version and apply formatting change [Chore] Bump Python version and apply formatting changes Dec 1, 2025
@ywang96
Copy link
Member

ywang96 commented Dec 1, 2025

@DarkLight1337 vllm-omni is currently based on 0.11.0 - is this change really necessary?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Dec 1, 2025

Oh, sorry I misread the comment in #33. We can merge this PR after the branch cut then.

"regex",
"ruff",
"pydantic",
"black>=23.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed by doc build as i recall. cc @Gaohan123

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Dec 1, 2025

Let me mark this as draft for now until it is confirmed that we can safely apply these changes without affecting the initial release

@DarkLight1337 DarkLight1337 reopened this Dec 1, 2025
@DarkLight1337 DarkLight1337 marked this pull request as draft December 1, 2025 07:02
@DarkLight1337 DarkLight1337 changed the title [Chore] Bump Python version and apply formatting changes [Chore] Bump Python version and apply formatting changes for v0.12 release Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Upgrade Python version before release

4 participants