Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Comments require Spaces at the beginning#1012

Closed
xichengliudui wants to merge 1 commit intovmware-archive:masterfrom
xichengliudui:fixconnent
Closed

Comments require Spaces at the beginning#1012
xichengliudui wants to merge 1 commit intovmware-archive:masterfrom
xichengliudui:fixconnent

Conversation

@xichengliudui
Copy link
Contributor

@xichengliudui xichengliudui commented Mar 29, 2019

Issue Ref: [Issue number related to this PR or None]
None

Description:
Comments require Spaces at the beginning (Obsessive compulsive disorder)

[PR Description]
Comments require Spaces at the beginning

TODOs:

  • Ready to review
  • Automated Tests
  • Docs

@xichengliudui
Copy link
Contributor Author

I am very confused. i am very confused, I did not modify any function, I just modified the comments.

./script/validate-vet
# command-line-arguments
cmd/kubeless/autoscale/autoscale.go:38:27: undefined: autoscaleCreateCmd
cmd/kubeless/autoscale/autoscale.go:38:47: undefined: autoscaleListCmd
cmd/kubeless/autoscale/autoscale.go:38:65: undefined: autoscaleDeleteCmd
Makefile:78: recipe for target 'validation' failed
make: *** [validation] Error 1
Exited with code 2

@andresmgot
Copy link
Contributor

hi @xichengliudui,

It seems that go vet behavior changed and we didn't notice since we haven't touched this file in a while. Do you mind changing ./script/validate-vet to execute go tool vet instead?

That seems the recommended way to run go vet against files from this issue: golang/go#23916

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants