This repository was archived by the owner on Dec 15, 2021. It is now read-only.
Improve code format for comment#1018
Merged
andresmgot merged 1 commit intovmware-archive:masterfrom Apr 9, 2019
Merged
Conversation
SataQiu
force-pushed
the
fix-format-20190403
branch
from
0c1fa32 to
532ffc8
Compare
Contributor
Author
|
I submitted a pull request but CI check failed. I don't know how my patch will be causing that failure. Can I get any help? |
Contributor
Author
|
I have run |
Contributor
|
Hi @SataQiu, you are hitting this issue: #1012 (comment) The new version of golang changed the behaviour of |
Contributor
Author
|
@andresmgot Thanks for your feedback. I'd be happy to work it out! |
3 tasks
Contributor
|
Thanks for the follow up PR! Can you rebase master in this one? Now your issue should be fixed. |
Contributor
Author
|
@andresmgot Thank you. That's what I'm going to do. |
SataQiu
force-pushed
the
fix-format-20190403
branch
from
532ffc8 to
90bbf07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Ref: [Issue number related to this PR or None]
Description:
Improve code format for comment
[PR Description]
Improve code format for comment
TODOs: