fix: handle undefined configuration export#2930
Merged
alexander-akait merged 9 commits intomasterfrom Sep 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 31 31
Lines 1684 1684
Branches 481 483 +2
=======================================
Hits 1602 1602
Misses 82 82
Continue to review full report at Codecov.
|
alexander-akait
previously approved these changes
Sep 4, 2021
Member
Author
|
@webpack/cli-team need approvals. |
snitin315
approved these changes
Sep 5, 2021
Merged
anshumanv
pushed a commit
that referenced
this pull request
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix and test
Did you add tests for your changes?
Yup, did in TDD fashion.
If relevant, did you update the documentation?
Not required.
Summary
Treat
undefinedconfiguration as a case forzero-configDoes this PR introduce a breaking change?
Nope.
Other information
/cc @alexander-akait