This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fix HeaderValue throwing an exception on legal characters#65
Closed
avasa wants to merge 4 commits intozendframework:masterfrom
Closed
Fix HeaderValue throwing an exception on legal characters#65avasa wants to merge 4 commits intozendframework:masterfrom
avasa wants to merge 4 commits intozendframework:masterfrom
Conversation
Member
|
Need tests |
Author
|
Any updates on this? |
| ["This\tis\ta test", 'assertTrue'], | ||
| ["This is\ta \r\n test", 'assertTrue'], | ||
| ["This\tis\ta\ntest", 'assertFalse'], | ||
| ["This is a \r\t\n \r\n test", 'assertFalse'], |
Member
There was a problem hiding this comment.
Please add a test case for this value ["This is a\r\n\ttest", 'asserTrue'],
Author
There was a problem hiding this comment.
I couldn't make it assert true. Breaks other the tests. Can you please take a look. Much appreciated.
Member
There was a problem hiding this comment.
It's not admisible push a commit with a wrong assertion just for to make the test to pass.
We prefer a failure in the test before to ship buggy code.
Please change the assertion.
Member
|
Now take a look to the line ~88 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull request #24 created Oct 7 2015.
Author of pull request has not responded since Nov 4 2015.
Can we please get this merged and resolved.
Thanks.