This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Complete #28#87
Merged
weierophinney merged 4 commits intozendframework:masterfrom May 5, 2016
weierophinney:hotfix/28
Merged
Conversation
Fix HeaderValue throwing an exception on legal characters
- Changes the ASCII out-of-range checks to use `> 127` instead of `> 126`, as 127 is the last ASCII character. - Removed the `testCannotBeConstructed()` test case, as irrelevant. - Added a data provider to test that wrapping header lines using `\r\n\t` is valid. It failed, and, as such, I updated the `isValid()` code to check for both ASCII 32 (SP) and 9 (TAB) when checking for line wrapping.
Had issues running CS sniffs under `--prefer-lowest`, so switched to phpcs. Which helped uncover a ton of CS issues, including underscore-prefixed properties and methods (most were updated, though the methods defined in the abstract protocol class were left due to the fact that they are an extension point).
weierophinney
added a commit
that referenced
this pull request
May 5, 2016
Member
|
@weierophinney Note this should be backported to 2.4 series |
Member
Author
|
@Maks3w why? I don't see any discussion around that on the original patch... |
Member
|
Because this bug was introduced by the zend mail headers security patch which it was applied to 2.4 too |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch incorporates the patches from #28, with the following additions:
validateValues()provider to ensure that\r\n\tis recognized as a valid header wrap.In addition, I was unable to run php-cs-fixer when testing after running
composer update --prefer-lowest. As such, this patch switches to phpcs, and corrects all CS issues flagged.Fix #28
Close #65