feat: Trait cost tweaks

[Blogaugis]

Purpose of the PR

Change the costs of advantages and disadvantages to ensure that they deal with increments that can easily be divided by 10.
Also adjust the costs of traits keeping in mind of presence of similar traits.

Describe the solution

Tweaking costs this way ensures that the player can fill out the 100/100 chapter customization, instead of having to be annoyed by 95/100, 85/100 and similar points of annoyance.

Describe alternatives you've considered

Add a freeform option for chapter customization.

Testing done

• Compilation;
• Chapter Creation Fiddling;
• Making to the game;
• Passing a turn.

Related links

https://discord.com/channels/714022226810372107/1344352277896626216/1344352283026133085

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• Gameplay Balance
  • Revised the point values for various in-game advantages and disadvantages to promote more strategic and balanced gameplay.

Walkthrough

In the revered file Create_0.gml, significant modifications have been enacted upon the value properties within the all_advantages and all_disadvantages arrays. Point values have been adjusted for various advantages, with notable increases for "Ambushers," "Bolter Drilling," and "Ryzan Patronage," while reductions have been applied to "Enemy: Tyranids," "Psyker Abundance," and others. The adjustments reflect a recalibration of gameplay mechanics, ensuring the harmonious operation of traits within the system. It is noteworthy that no alterations were made to the declarations of exported or public entities, thus preserving the integrity of the interface.

Possibly related PRs

• fix: Equal specialist distr fix for obliterated #484 – The adjustments in this PR affect the "Obliterated" disadvantage, complementing the modifications made to its point value in the current update.
• fix: Trait cost adjustments #490 – This PR shares a direct connection, as it also involves modifications to the value properties of advantages and disadvantages within the Create_0.gml file.
• feat: Add "Depleted Gene-seed Stocks" disadvantage #527 – This PR introduces a new disadvantage to the all_disadvantages array, indicating a direct relationship in terms of modifications to the same data structure.

Suggested labels

PR: Feature, PR: Fix, Size: Medium

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

Proposed Changes:
Advantages:
Ambushers - from 20 to 30;
Boarders - from 30 to 20
Bolter Drilling: - from 25 to 30; (Has no obvious drawback and buffs your main weapons)
Crafters - from 35 to 40; (Techmarine buff)
Enemy: Tyranids - From 25 to 20; (streamlining with other Enemy: ... traits)
Lightning Warriors - from 35 to 20;
Reverent Guardians - from 25 to 20;
Tech-Brothers - from 25 to 30; (Techmarine + Admech buff)
Siege Masters - from 15 to 20;
Medicae Primacy - from 25 to 20;
Ryzan Patronage - from 25 to 30;
Disadvantages:
Blood Debt - from 50 to 30;
Fresh Blood - from 30 to 20;
Never Forgive - from 15 to 10; (Not sure if event line is functional at the moment).
Sieged - from 30 to 20; (Relatively slight handicap)
Tech-Heresy - from 30 to 20; (Needs rework at some point)
Psyker Intolerant - from 20 to 10; (Might be worthwhile to return to 20)
Obliterated - From 60 to 40;
Enduring Angels - from 50 to 30; (Perhaps could be lowered to 20)
Serpents Delight - from 70 to 30; (No idea why it is/was more expensive than obliterated)
Weakened Apothecarion - from 25 to 10;
Small Reclusiam - from 25 to 10;
Barren Librarius - from 25 to 10.

[Blogaugis]

Also, needs #519 to make obliterated price change make sense.

[Blogaugis]

@KRdaMystic
Tweaked some trait costs as per our discussion. Let me know what you think.

[KRdaMystic]

-Advantages
Ambushers = 30
Boarders = 30
Weapon Specialtys = 40
Crafters = 40
Enemy traits = 20
Lightning Warriors = 30
Specialist traits (Adv & Disadv) = 20
Assault Doctrine = 20
Devastator Doctrine = 40
Siege Masters = 20
Venerable Ancients = 40
-Disadvantages
Blood Debt = 50
Fresh Blood = 20
Never Forgive = 20
Sieged = 40
Psyker Intolerant = 30
Obliterated = 80
Enduring angels = 30
Serpents Delight = 50

[Blogaugis]

• Lightning Warriors = 30

Not worth that much, but okay.

Specialist traits (Adv & Disadv) = 20

This would be: Psyker Abundance, Reverent Guardians, Tech-Brothers, Medicae Primacy;
Barren Librarius, Small Reclusiam, Tech-Heresy(?), Weakened Apothecarion.

• Assault Doctrine = 20 Devastator Doctrine = 40

Do you have plans to increase viability of melee armaments?

We'll discuss in relevant channel more.

[Blogaugis]

@KRdaMystic Can you now approve of this PR?
I tweaked the prices as you wanted them.

[Blogaugis]

@EttyKitty Ok, so, you want me to close this PR, or should I just make it that all traits cost 0?