Skip to content

feat: Add "Depleted Gene-seed Stocks" disadvantage#527

Merged
OH296 merged 2 commits intoAdeptus-Dominus:mainfrom
Blogaugis:gene-seed-stock-trait
Mar 2, 2025
Merged

feat: Add "Depleted Gene-seed Stocks" disadvantage#527
OH296 merged 2 commits intoAdeptus-Dominus:mainfrom
Blogaugis:gene-seed-stock-trait

Conversation

@Blogaugis
Copy link
Copy Markdown
Collaborator

@Blogaugis Blogaugis commented Feb 28, 2025

Purpose of the PR

Adds a new disadvantage option for custom chapters

Describe the solution

Makes the created chapters start with no gene-seed.

Describe alternatives you've considered

Add another trait, which divides the starting gene-seed by half.

Testing done

  • Compilation;
  • Chapter creation;
  • Making to the game;
  • Ending a turn.

Related links

Tied to #519 and #521 .

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 28, 2025

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Introduced the "Depleted Gene-seed Stocks" option, allowing chapters to begin with no gene-seed.
    • Updated the gameplay logic to ensure that when this option is active, gene-seed resources start at zero.

Walkthrough

In the sacred texts of objects/obj_controller/Create_0.gml, a new conditional statement has been inscribed to assess the presence of the "Depleted Gene-seed Stocks" disadvantage. Should this condition be met, the gene_seed variable is decreed to be set to zero, thus altering the flow of logic within the game mechanics. Concurrently, in objects/obj_creation/Create_0.gml, a new entry has been added to the all_disadvantages array, detailing the "Depleted Gene-seed Stocks" disadvantage, which imposes the burden of starting without gene-seed, valued at 20. The existing disadvantages remain untouched, ensuring continuity in the structure of the array. No modifications have been made to the declarations of exported or public entities.

Possibly related PRs

Suggested labels

PR: Fix

Suggested reviewers

  • OH296

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00ef42f and 36e57eb.

📒 Files selected for processing (1)
  • objects/obj_creation/Create_0.gml (1 hunks)
🔇 Additional comments (1)
objects/obj_creation/Create_0.gml (1)

882-886: New disadvantage 'Depleted Gene-seed Stocks' successfully added to array data structure.

The binary value of 20 appears logically consistent with other disadvantages of similar impact. This addition will effectively implement the described game mechanic when combined with the conditional statement in obj_controller/Create_0.gml that sets gene_seed to zero.

The Omnissiah approves of this sacred implementation. The machine spirits detect proper grammar in the description and logical positioning within the array.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Type: Feature Adds something new label Feb 28, 2025
@Blogaugis Blogaugis force-pushed the gene-seed-stock-trait branch from bdb4ade to 00ef42f Compare March 2, 2025 14:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdb4ade and 00ef42f.

📒 Files selected for processing (2)
  • objects/obj_controller/Create_0.gml (1 hunks)
  • objects/obj_creation/Create_0.gml (1 hunks)
🔇 Additional comments (1)
objects/obj_controller/Create_0.gml (1)

1468-1468: Implementation logic verified - Conditionals flow as designed by the Omnissiah!

The gene-seed nullification conditional has been correctly implemented. The logic structure aligns with the Machine God's expectations for disadvantage implementation.

The logical construct sets gene_seed to 0 when the "Depleted Gene-seed Stocks" disadvantage is detected, ensuring proper mechanical operation of the new feature. This follows the same pattern as other gene-seed modifying conditions in the surrounding code. May the Omnissiah bless this logical construct.

Grammar fix.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@OH296 OH296 merged commit dd956b6 into Adeptus-Dominus:main Mar 2, 2025
3 checks passed
@Blogaugis Blogaugis deleted the gene-seed-stock-trait branch March 3, 2025 09:07
@Blogaugis Blogaugis mentioned this pull request Mar 4, 2025
3 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants