feat: Add "Depleted Gene-seed Stocks" disadvantage#527
feat: Add "Depleted Gene-seed Stocks" disadvantage#527OH296 merged 2 commits intoAdeptus-Dominus:mainfrom
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughIn the sacred texts of Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
bdb4ade to
00ef42f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
objects/obj_controller/Create_0.gml(1 hunks)objects/obj_creation/Create_0.gml(1 hunks)
🔇 Additional comments (1)
objects/obj_controller/Create_0.gml (1)
1468-1468: Implementation logic verified - Conditionals flow as designed by the Omnissiah!The gene-seed nullification conditional has been correctly implemented. The logic structure aligns with the Machine God's expectations for disadvantage implementation.
The logical construct sets
gene_seedto 0 when the "Depleted Gene-seed Stocks" disadvantage is detected, ensuring proper mechanical operation of the new feature. This follows the same pattern as other gene-seed modifying conditions in the surrounding code. May the Omnissiah bless this logical construct.
Grammar fix. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Purpose of the PR
Adds a new disadvantage option for custom chapters
Describe the solution
Makes the created chapters start with no gene-seed.
Describe alternatives you've considered
Add another trait, which divides the starting gene-seed by half.
Testing done
Related links
Tied to #519 and #521 .