Revamp the existing "Using the VE" documentation#1055
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1055 +/- ##
===========================================
+ Coverage 95.20% 95.38% +0.18%
===========================================
Files 81 79 -2
Lines 6889 6876 -13
===========================================
Hits 6559 6559
+ Misses 330 317 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arne-exe
left a comment
There was a problem hiding this comment.
Well done @davidorme, the structure is much clearer and it's a lot easier to understand how different files of the VE link together.
…, replaced climate dummy data with actual dummy values to avoid confusion
|
|
||
| * `time`: This dimension is used to index time steps along configured time extent | ||
| for the simulation. Some variables only need to set the initial conditions and do | ||
| not need a time axis, but other forcing variables (like temperature and |
There was a problem hiding this comment.
| not need a time axis, but other forcing variables (like temperature and | |
| not need a time axis, but other forcing variables (like reference temperature and |
|
@davidorme this is a really fantastic update - thank you for doing this! @Baizurah @nickwctan @lelavathy @hrlai I definitely recommend you read through it, though I know you're quite familiar with the model at this point. This is very nicely and logically laid out. It would be worthwhile to get your feedback on clarity. |
vgro
left a comment
There was a problem hiding this comment.
Happy for you to merge once the stalled tests pass
Thanks @annarallings. This has been reviewed by you, @arne-exe and @vgro, so we're going to merge this down into @Baizurah @nickwctan @lelavathy @hrlai - that doesn't mean this is the final version - just that we want to bank what we have and not have the PR sitting around getting out of sync! Please do read the new section and let us know if there are any other things to improve. |
|
Great work on this PR 🙌 Really nice to see the clearer flow, which is super helpful. I’ll need to go through this again since there’s so much more information here compared to the previous version. I agree on the idea of documenting NetCDF vs CSV split, which has been mentioned in other issues/discussion. It will be helpful to know which inputs belong to NetCDF (assuming this will be for spatial/gridded ie climate) vs CSV (categorical/functional definitions ie: animal traits). Might be worth considering: -As a visual person, I think adding a simple folder layout/structure diagram would go a long way where it is relevant, for example, folder structure/showing how NetCDF vs CSV files fit together. I will give the doc deeper read and be back if anything relevant. |
You absolutely can - although closed issues get less attention, so tagging people is useful to get eyes on your comment. The other thing you can do is to add new issues to this repo to suggest the changes you'd like, in this case ideally as new sub-issues of the doc revamp meta issue (#1035) - that gives us specific things to action and they don't go away until we've closed them.
This is actually less important than the example data makes it look. All of the data files are loaded from paths that are set in the configuration, so they could be organised in any structure. Probably better to have them organised, but the configured paths are the key bit!
Yup - that would be new pages on preparing data files and configuration, probably with R and Python subpages. |
|
Thanks for doing this. 👍🏼 Reading flow is much better |
Description
This PR is tidying up the existing "Using the VE" documentation. The main changes are:
I've created an overview of the main pages as a landing page for using the VE rather than diving straight into installation.
I've separated the structure out a bit so that we now have specific pages for "Installing VE" and then "The example data".
The example data variable tables were wildly out of date. I've moved to a system where each netCDF file has dataset description and then variable descriptions and units in the file attributes. That's good practice for NetCDF files anyway but additionally the example data page now has a function to automatically create the variable tables from the files, so everything stays updated automatically as long as the files are annotated correctly.
The example data page now basically avoids showing or mentioning the data generation scripts except in passing at the end. I think the file contents are the key thing and those generation scripts are distracting.
Important
This bit isn't complete - some of the NetCDF files need to have units and descriptions added to get the information into the tables. Each file needs to have a
dataset_descriptionattribute and then each variable needsunitsanddescriptionattributes. The code below shows these being set in the climate data generation file.virtual_ecosystem/virtual_ecosystem/example_data/generation_scripts/climate_example_data.py
Lines 161 to 188 in f90ec84
bashstuff - it shows command syntax but the execution of the model runs on code that is entirely hidden.ve_runcommand help.ipynbfile to capture the outputs and hopefully allow it to be built to html using the existing outputs.I've built the docs - this is the key section:
https://virtual-ecosystem.readthedocs.io/en/1050-revamp-the-existing-using-the-ve-documentation/using_the_ve/overview.html
Fixes #1050
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks