Skip to content

Abiotic part of 1050#1064

Merged
vgro merged 7 commits into1050-revamp-the-existing-using-the-ve-documentationfrom
abiotic_part_of_1050
Oct 1, 2025
Merged

Abiotic part of 1050#1064
vgro merged 7 commits into1050-revamp-the-existing-using-the-ve-documentationfrom
abiotic_part_of_1050

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Sep 30, 2025

This PR simplifies the abiotic data for ve_example and removes some files that are no longer needed as part of #1050

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro removed the request for review from jacobcook1995 September 30, 2025 15:27
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.43%. Comparing base (4e38c42) to head (f3ba5c7).

Files with missing lines Patch % Lines
...le_data/generation_scripts/climate_example_data.py 0.00% 23 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           1050-revamp-the-existing-using-the-ve-documentation    #1064      +/-   ##
=======================================================================================
+ Coverage                                                95.14%   95.43%   +0.29%     
=======================================================================================
  Files                                                       81       79       -2     
  Lines                                                     6903     6882      -21     
=======================================================================================
  Hits                                                      6568     6568              
+ Misses                                                     335      314      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 October 1, 2025 12:52
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme
Copy link
Copy Markdown
Collaborator

@vgro Do you want to go ahead and merge these down into #1050 and then I'll merge #1050 into develop. I think we've had enough oversight to know that these two PRs will move develop on. We can add new PRs to address further updates rather than letting these hang around.

@vgro vgro merged commit 8636ee9 into 1050-revamp-the-existing-using-the-ve-documentation Oct 1, 2025
58 of 68 checks passed
@vgro vgro deleted the abiotic_part_of_1050 branch October 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants