Skip to content

Publish version 0.1.0a0#401

Merged
davidorme merged 2894 commits intomainfrom
release/0.1.0
Mar 4, 2024
Merged

Publish version 0.1.0a0#401
davidorme merged 2894 commits intomainfrom
release/0.1.0

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

Description

This PR is to merge the current develop into the release branch main so that we can then publish the current code onto PyPI and get the project name fixed in PyPI. As part of this process, I'll also run a test publish to TestPyPI.

This isn't a particular target hit or goal achieved, but it is worth making sure we have everything set up and have an official PyPI page for the upcoming paper submission.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

davidorme and others added 30 commits October 12, 2023 17:39
tly - cleanly close the file logger from inside with blocks as well as on test failures
…ual_rainforest-package-always-causes-models-to-be-loaded

Moving to a single registry and importing on request not automatically
…iling-all-unit-tests-of-logger-output-to-fail

Better handling of file loggers in testing
Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've just made a couple of suggestions to move files from one place to another.

To automate the pubisling to PyPI when you create a new release, I'd suggest you follow something similar to what we implemented in this other project: https://github.com/EnergySystemsModellingLab/MUSE_OS/blob/develop/.github/workflows/publish.yml
You will need to setup accounts in PyPI and TestPyPI firs, obviously.

@davidorme
Copy link
Copy Markdown
Collaborator Author

@dalonsoa The PR template is in a recognised location, but I agree it's neater in .github. It seems dependabot.yml must be in .github though, so I botched a PR two years ago 😄.

Having an automatic PyPI setup would be good - I might just do this one manually to get it released and then we can revisit that for the next release?

@dalonsoa
Copy link
Copy Markdown
Collaborator

dalonsoa commented Mar 4, 2024

Sounds good!

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add :-)

@davidorme
Copy link
Copy Markdown
Collaborator Author

Just pulling in the progress update from #403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants