build(client): use per-platform team IDs for iOS and macOS signing#2718
Merged
build(client): use per-platform team IDs for iOS and macOS signing#2718
Conversation
iOS and macOS (Mac Catalyst) require different Apple Developer team IDs. Use Xcode's SDK-conditional build setting syntax to set the iOS team (WP4DKSWWZM) as the default and override with the macOS team (QT8Z3Q9V3A) when building against the macOS SDK. Also supports a DEVELOPMENT_TEAM env var override in the build script, so external contributors can set their own team ID without editing project files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates Apple code-signing configuration so iOS and macOS (Mac Catalyst) builds use different Apple Developer Team IDs by default, while allowing external contributors to override the team ID via an environment variable during command-line release builds.
Changes:
- Add
DEVELOPMENT_TEAMenvironment variable override to the Cordova Apple release build (xcodebuild archive) invocation. - Update Xcode project build settings to default to the iOS team ID and override to the macOS team ID when building with the macOS SDK.
- Document the new
DEVELOPMENT_TEAMoverride for external contributors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/cordova/build.action.mjs | Adds optional DEVELOPMENT_TEAM=... argument to xcodebuild for release builds. |
| client/src/cordova/apple/xcode/Outline.xcodeproj/project.pbxproj | Sets iOS default team ID and uses SDK-conditional override for macOS builds. |
| client/src/cordova/apple/OutlineLib/OutlineLib.xcodeproj/project.pbxproj | Applies the same per-SDK team ID approach for the library/extension project. |
| client/src/cordova/apple/README.md | Documents the env var override for command-line release builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Note for our future selves:
|
ohnorobo
reviewed
Mar 2, 2026
Contributor
ohnorobo
left a comment
ohnorobo
left a comment
There was a problem hiding this comment.
Thanks, this will help with unblocking.
ohnorobo
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS and macOS (Mac Catalyst) require different Apple Developer team IDs. Use Xcode's SDK-conditional build setting syntax to set the iOS team (WP4DKSWWZM) as the default and override with the macOS team (QT8Z3Q9V3A) when building against the macOS SDK.
Also supports a DEVELOPMENT_TEAM env var override in the build script, so external contributors can set their own team ID without editing project files.