Skip to content

build(client): use per-platform team IDs for iOS and macOS signing #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fortuna merged 1 commit into from
Mar 2, 2026
Merged

build(client): use per-platform team IDs for iOS and macOS signing #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions client/src/cordova/apple/OutlineLib/OutlineLib.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.getoutline.client.VpnExtensionTest;
Expand All @@ -348,7 +349,8 @@
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.getoutline.client.VpnExtensionTest;
Expand Down Expand Up @@ -495,7 +497,8 @@
CODE_SIGN_ENTITLEMENTS = VpnExtension/VpnExtension.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = VpnExtension/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = VpnExtension;
Expand Down Expand Up @@ -532,7 +535,8 @@
CODE_SIGN_ENTITLEMENTS = VpnExtension/VpnExtension.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = VpnExtension/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = VpnExtension;
Expand Down
9 changes: 9 additions & 0 deletions client/src/cordova/apple/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ Apple is quite particular when it comes to making sure your app is properly sign

### External Contributors

For **release builds via the command line**, set the `DEVELOPMENT_TEAM` environment variable to override the default team ID without editing any project files:

```sh
DEVELOPMENT_TEAM=<your_team_id> npm run action client/src/cordova/build ios -- --buildMode=release
DEVELOPMENT_TEAM=<your_team_id> npm run action client/src/cordova/build macos -- --buildMode=release
```

For **development in Xcode**:

1. Select the "Team" for your own account.
1. Change the bundle identifier (e.g. `org.outline.ios.client`) to something unique.
1. Remove the app group `group.org.getoutline.client`.
Expand Down
6 changes: 4 additions & 2 deletions client/src/cordova/apple/xcode/Outline.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,8 @@
CODE_SIGN_ENTITLEMENTS = Outline/Outline.entitlements;
CODE_SIGN_IDENTITY = "iPhone Developer";
COPY_PHASE_STRIP = NO;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
"Outline/Plugins/cordova-plugin-outline",
Expand Down Expand Up @@ -854,7 +855,8 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
COPY_PHASE_STRIP = YES;
DEVELOPMENT_TEAM = QT8Z3Q9V3A;
DEVELOPMENT_TEAM = WP4DKSWWZM;
"DEVELOPMENT_TEAM[sdk=macosx*]" = QT8Z3Q9V3A;
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
"Outline/Plugins/cordova-plugin-outline",
Expand Down
7 changes: 6 additions & 1 deletion client/src/cordova/build.action.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,18 @@ async function appleDebug(platform) {
}

async function appleRelease(platform) {
const teamIdArgs = process.env.DEVELOPMENT_TEAM
? [`DEVELOPMENT_TEAM=${process.env.DEVELOPMENT_TEAM}`]
: [];

return spawnStream(
'xcodebuild',
'clean',
...getXcodeBuildArgs(platform),
'archive',
'-configuration',
'Release'
'Release',
...teamIdArgs
);
}

Expand Down
Loading