Merged
Conversation
winder
changed the title
winder
commented
Aug 16, 2022
Comment on lines
+169
to
+173
| @JsonProperty("sp") | ||
| public Map<String,Object> stateProof = null; | ||
|
|
||
| @JsonProperty("spmsg") | ||
| public Map<String,Object> stateProofMessage = null; |
Contributor
Author
There was a problem hiding this comment.
These types were really complicated, do they need to be added?
shiqizng
reviewed
Aug 16, 2022
Contributor
shiqizng
left a comment
shiqizng
left a comment
There was a problem hiding this comment.
this looks good. Using BigInteger type seems odd to me.
shiqizng
approved these changes
Aug 16, 2022
|
think we should remove the old |
id-ms
reviewed
Aug 18, 2022
id-ms
approved these changes
Aug 29, 2022
winder
force-pushed
the
will/state-proof-support
branch
from
10726d7 to
29c6e6e
Compare
id-ms
approved these changes
Aug 30, 2022
ahangsu
added a commit
that referenced
this pull request
Sep 2, 2022
* Ignore copied over txt test resource files (#342) * Github-Actions: Adding pr title and label checks (#339) * Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351) * AVM: Consolidate TEAL and AVM versions (#348) * Testing: Modify cucumber steps to use dev mode network (#350) * DevTools: adding source map decoder (#352) * adding source map decoder * bump to 1.17.0 * Enhancement: Use Sandbox for Testing (#363) * Bugfix: Pass verbosity to the harness and sandbox (#371) * Enhancement: Deprecating use of langspec (#367) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * StateProofs: Add State Proof support. (#360) * Regenerate client. * Implement cucumber response tests. * Implement path tests, update Makefile, update README. * Revert * Add state proof fields to Transaction. * Update README.md * Update src/main/java/com/algorand/algosdk/transaction/Transaction.java * publish results. * Add transaction-root-256 * dummy commit to avoid check pr category * dummy commit to kill previous dummy commit Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for new state proof endpoints and transaction deserialization.