Skip to content

Bug-Fix: Pass verbosity to the harness and sandbox#371

Merged
tzaffi merged 1 commit intodevelopfrom
bugfix-passthru-verbosity
Aug 23, 2022
Merged

Bug-Fix: Pass verbosity to the harness and sandbox#371
tzaffi merged 1 commit intodevelopfrom
bugfix-passthru-verbosity

Conversation

@tzaffi
Copy link
Copy Markdown
Contributor

@tzaffi tzaffi commented Aug 23, 2022

Summary

Following up from the companion SDK Testing Bugfix PR, we're going to pass through verbosity to the harness script via a new -v flag.

For further context: here is what SDK Testing Bugfix PR says:

The sandbox is always defaulting to release and the generated config.harness isn't sticking because the verbose flag is provided in the wrong order.

Additionally, after refactoring the SDK Sandboxization PR's to no longer overwrite .env, there is no way to pass through the verbosity, except by overwriting. The PR re-enables passing through by also reading VERBOSE_HARNESS as a flag (either -v or --verbose).

@tzaffi tzaffi added the Bug-Fix label Aug 23, 2022
@tzaffi tzaffi changed the title Bugfix: Pass verbosity to the harness and sandbox Bug-Fix: Pass verbosity to the harness and sandbox Aug 23, 2022
@tzaffi tzaffi requested a review from ahangsu August 23, 2022 21:35
@tzaffi tzaffi merged commit a0e5eb2 into develop Aug 23, 2022
@tzaffi tzaffi deleted the bugfix-passthru-verbosity branch August 23, 2022 22:13
ahangsu added a commit that referenced this pull request Sep 2, 2022
* Ignore copied over txt test resource files (#342)

* Github-Actions: Adding pr title and label checks (#339)

* Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351)

* AVM:  Consolidate TEAL and AVM versions (#348)

* Testing: Modify cucumber steps to use dev mode network  (#350)

* DevTools: adding source map decoder (#352)

* adding source map decoder

* bump to 1.17.0

* Enhancement: Use Sandbox for Testing (#363)

* Bugfix: Pass verbosity to the harness and sandbox (#371)

* Enhancement: Deprecating use of langspec (#367)

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* StateProofs: Add State Proof support. (#360)

* Regenerate client.

* Implement cucumber response tests.

* Implement path tests, update Makefile, update README.

* Revert

* Add state proof fields to Transaction.

* Update README.md

* Update src/main/java/com/algorand/algosdk/transaction/Transaction.java

* publish results.

* Add transaction-root-256

* dummy commit to avoid check pr category

* dummy commit to kill previous dummy commit

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: Jack <87339414+algojack@users.noreply.github.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants