Enhancement: Use Sandbox for Testing by tzaffi · Pull Request #363 · algorand/java-algorand-sdk

tzaffi · 2022-08-17T16:57:48Z

Blocked by algorand/algorand-sdk-testing#220

...which explains most of the removed steps.

Additional Unused Steps via Unused Steps Analysis Script

according to this spreadsheet

the transaction should still be the same
I get transactions by address only
I get transactions by address and date
@Given("indexer client {int} at {string} port {int} with token {string}")
@Given("key registration transaction parameters {int} {int} {int} {string} {string} {string} {int} {int} {int} {string} {string}")
@When("I create the payment transaction")
@When("I create the key registration transaction")
@Then("I can get the transaction by ID")
@When("I read a transaction {string} from file {string}")
@When("I write the transaction to file")
@Then("I do my part")
@When("I get recent transactions, limited by {int} transactions")

…nd-sdk into sandbox-sdk-testing

tzaffi · 2022-08-19T17:33:03Z

+harness:
+	./test-harness.sh
+
+docker-javasdk-build:
+	# Build SDK testing environment
+	docker build -t java-sdk-testing .
+
+docker-javasdk-run:
+	# Launch SDK testing
+	docker run -it --network host java-sdk-testing:latest

-docker-test:
-	./run_integration_tests.sh
+docker-test: harness docker-javasdk-build docker-javasdk-run


Breaking up make docker-test into:

pull down the harness

build the javasdk docker

run the javasdk docker (which runs make unit and make integration)

tzaffi · 2022-08-19T17:34:15Z

+UNIT_TAGS :=  "$(subst :, or ,$(shell awk '{print $2}' src/test/unit.tags | paste -s -d: -))"
+INTEGRATION_TAGS := "$(subst :, or ,$(shell awk '{print $2}' src/test/integration.tags | paste -s -d: -))"


cucumber tags now reside in:

src/test/integration.tags

src/test/unit.tags

tzaffi · 2022-08-22T00:17:04Z

+	mvn test -Dtest=com.algorand.algosdk.integration.RunCucumberIntegrationTest -Dcucumber.filter.tags=$(INTEGRATION_TAGS)
+
+display-all-java-steps:
+	find src/test/java/com/algorand/algosdk -name "*.java" | xargs grep "io.cucumber.java.en" 2>/dev/null | grep -v Binary | cut -d: -f1 | sort | uniq | xargs grep -E "@(Given|Then|When)"


Command that generates input for Unused Steps Analysis script

michaeldiamant

Approval assumes SDK_TESTING_BRANCH reset to master prior to merge.

* Ignore copied over txt test resource files (#342) * Github-Actions: Adding pr title and label checks (#339) * Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351) * AVM: Consolidate TEAL and AVM versions (#348) * Testing: Modify cucumber steps to use dev mode network (#350) * DevTools: adding source map decoder (#352) * adding source map decoder * bump to 1.17.0 * Enhancement: Use Sandbox for Testing (#363) * Bugfix: Pass verbosity to the harness and sandbox (#371) * Enhancement: Deprecating use of langspec (#367) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * StateProofs: Add State Proof support. (#360) * Regenerate client. * Implement cucumber response tests. * Implement path tests, update Makefile, update README. * Revert * Add state proof fields to Transaction. * Update README.md * Update src/main/java/com/algorand/algosdk/transaction/Transaction.java * publish results. * Add transaction-root-256 * dummy commit to avoid check pr category * dummy commit to kill previous dummy commit Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

try it all out on circle

cc9d96f

tzaffi added the Enhancement label Aug 17, 2022

tzaffi marked this pull request as draft August 17, 2022 16:58

tzaffi commented Aug 17, 2022

View reviewed changes

Comment thread test-harness.sh Outdated

Update test-harness.sh

abe612d

tzaffi commented Aug 17, 2022

View reviewed changes

Comment thread test-harness.sh Outdated

missing dbl quote

7216d3f

tzaffi commented Aug 18, 2022

View reviewed changes

Comment thread .test-env Outdated

tzaffi and others added 4 commits August 17, 2022 21:15

Update .test-env

68846c6

verbose_harness=0

73d0c03

remove EvalDelta & Indexer steps + don't use indexer v1

382bb76

un-reformat

ce7c8af

michaeldiamant reviewed Aug 18, 2022

View reviewed changes

Comment thread Makefile Outdated

Zeph Grunschlag added 3 commits August 18, 2022 14:22

quotes

4ec4364

oops - need to include the tag files

e750f95

Merge remote-tracking branch 'origin' into sandbox-sdk-testing

b61d485

tzaffi commented Aug 19, 2022

View reviewed changes

Comment thread Makefile Outdated

tzaffi and others added 3 commits August 19, 2022 11:43

Update Makefile

97e9ecd

Merge branch 'sandbox-sdk-testing' of github.com:algorand/java-algora…

93dbee4

…nd-sdk into sandbox-sdk-testing

following fuzzy matcher - remove 3 step definitions

6b68325

tzaffi marked this pull request as ready for review August 19, 2022 17:04

tzaffi requested review from ahangsu, michaeldiamant and winder August 19, 2022 17:08

tzaffi commented Aug 19, 2022

View reviewed changes

Comment thread .test-env Outdated

tzaffi commented Aug 19, 2022

View reviewed changes

Comment thread .test-env Outdated

tzaffi commented Aug 19, 2022

View reviewed changes

Comment thread Makefile Outdated

guard the find regex

e1a7668

Zeph Grunschlag added 2 commits August 21, 2022 16:04

removing Unused Steps Analysis Unused Steps

58e4279

lintings

0ef0c20

tzaffi commented Aug 22, 2022

View reviewed changes

add a note about standing up test harness without make docker-test

41f1436

michaeldiamant approved these changes Aug 22, 2022

View reviewed changes

Update .test-env

bffb5c9

tzaffi merged commit dc9a4b7 into develop Aug 22, 2022

tzaffi deleted the sandbox-sdk-testing branch August 22, 2022 16:17

michaeldiamant mentioned this pull request Aug 26, 2022

Enhancement: Remove the dataset indexer images and the indexer.feature + utilize sandbox for algod/indexer/postgres containers algorand/algorand-sdk-testing#220

Merged

8 tasks

algojack mentioned this pull request Aug 31, 2022

FOR REVIEW ONLY - java-algorand-sdk 1.18.0 #378

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement: Use Sandbox for Testing#363

Enhancement: Use Sandbox for Testing#363
tzaffi merged 18 commits intodevelopfrom
sandbox-sdk-testing

tzaffi commented Aug 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzaffi Aug 19, 2022

Uh oh!

tzaffi Aug 19, 2022

Uh oh!

Uh oh!

tzaffi Aug 22, 2022 •

edited

Loading

Uh oh!

michaeldiamant left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		UNIT_TAGS := "$(subst :, or ,$(shell awk '{print $2}' src/test/unit.tags \| paste -s -d: -))"
		INTEGRATION_TAGS := "$(subst :, or ,$(shell awk '{print $2}' src/test/integration.tags \| paste -s -d: -))"

Conversation

tzaffi commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Blocked by algorand/algorand-sdk-testing#220

Additional Unused Steps via Unused Steps Analysis Script

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzaffi Aug 19, 2022

Choose a reason for hiding this comment

Uh oh!

tzaffi Aug 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzaffi Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaeldiamant left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tzaffi commented Aug 17, 2022 •

edited

Loading

tzaffi Aug 22, 2022 •

edited

Loading