Skip to content

Feat ja translation skill#62086

Open
HARDIK-WEB-OSS wants to merge 3 commits intoapache:mainfrom
HARDIK-WEB-OSS:feat-ja-translation-skill
Open

Feat ja translation skill#62086
HARDIK-WEB-OSS wants to merge 3 commits intoapache:mainfrom
HARDIK-WEB-OSS:feat-ja-translation-skill

Conversation

@HARDIK-WEB-OSS
Copy link

Description

closes: #61997
related: #61984

Defined translation agent skills for the Japanese (ja) locale according to #62059.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Generated-by: [Gemini] following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:google Google (including GCP) related issues labels Feb 17, 2026
@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from ae79d92 to 5283b59 Compare February 18, 2026 08:56
@HARDIK-WEB-OSS
Copy link
Author

Hi @shahar1 and @Dev-iL, I have reverted the unrelated BigQuery changes as suggested. I have also updated the license header to include the URL per the feedback. My branch is now clean and only contains the Japanese locale translation agent skill. Ready for another look!

@Dev-iL
Copy link
Collaborator

Dev-iL commented Feb 18, 2026

I have also updated the license header to include the URL per the feedback.

I still don't see it.

@HARDIK-WEB-OSS
Copy link
Author

Hi @Dev-iL and @shahar1, I've fixed the license header to the minimal 3-line format as per the feedback. I've also squashed the commits and cleaned the branch history. Re-opened and ready for a final review.

@HARDIK-WEB-OSS
Copy link
Author

HARDIK-WEB-OSS commented Feb 24, 2026

Hi @jason810496 and @shahar1, I have updated the branch. All feedback from @rsanda has been fully incorporated, and the technical structure has been approved by @Dev-iL.
Looking forward to the final review from @uranusjr or @sekikn so we can get this merged. Thanks for your time!

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from f4c3914 to 3c52249 Compare February 26, 2026 17:56
@HARDIK-WEB-OSS
Copy link
Author

Hi @jason810496 @shahar1, just a quick update: the branch is synced. Ready for review.
I'm happy to help with any further polish for the Japanese locale or agent skills if needed. Cheers!

@shahar1
Copy link
Contributor

shahar1 commented Feb 27, 2026

Hi @jason810496 @shahar1, just a quick update: the branch is synced. Ready for review.
I'm happy to help with any further polish for the Japanese locale or agent skills if needed. Cheers!

Static checks seem to fail, please fix.
Also, please refrain from tagging me or Jason in every message - we already get notified about this PR since the first tagging.
Since I'm on a low availability these days, please consider that it might take me a while until I'll be able to review it properly.
Thank you!

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch 2 times, most recently from 2146e53 to c8b7257 Compare March 3, 2026 14:47
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsanda,

Could you please do a final check of the translation skill terminology when you have time before I merge it? Thanks!

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from b984774 to af10016 Compare March 4, 2026 17:03
@rsanda
Copy link
Contributor

rsanda commented Mar 5, 2026

Thanks a lot!

All looks good except for the following:

queued | キュー待ち |

I need to check the code for the current translation. I think it should be "キュー済み."
Please give me sometime to double check it as I'm traveling and I don't have my PC with me.

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from bf9e347 to f088b2c Compare March 5, 2026 03:49
@HARDIK-WEB-OSS
Copy link
Author

Thanks a lot!

All looks good except for the following:

queued | キュー待ち |

I need to check the code for the current translation. I think it should be "キュー済み." Please give me sometime to double check it as I'm traveling and I don't have my PC with me.

Confirmed in common.json that the existing standard for 'queued' is '待機中'. I have updated ja.md to ensure 100% consistency with the current UI. Ready for final review and re-assignment.

@rsanda
Copy link
Contributor

rsanda commented Mar 11, 2026

@HARDIK-WEB-OSS
Could you please change the following translations as below as common.json?

deferred": "延期済"
"failed": "失敗した"
"backfill": "過去分の再実行"
upstream_failed": "上流が失敗しました"

Also, put a space after English words as the Spacing rule states:

| Dag Run | Dag実行 | |

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch 2 times, most recently from b10bd47 to 42b0056 Compare March 11, 2026 10:45
@HARDIK-WEB-OSS
Copy link
Author

@HARDIK-WEB-OSS Could you please change the following translations as below as common.json?

deferred": "延期済"
"failed": "失敗した"
"backfill": "過去分の再実行"
upstream_failed": "上流が失敗しました"

Also, put a space after English words as the Spacing rule states:

| Dag Run | Dag実行 | |

All terminology and spacing updates are live. Updated deferred → 延期済, failed → 失敗した, backfill → 過去分の再実行, upstream_failed → 上流が失敗しました. Half-width spacing rule applied consistently across all Triggerer and Dag entries. JSON structure verified. Ready for final review

@rsanda
Copy link
Contributor

rsanda commented Mar 16, 2026

Thanks Hardik.
LGTM.

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved from my side.
Since @rsanda has approved it, I think we can merge this 🙌

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from d39f825 to 3dc1fb6 Compare March 17, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define translation agent skill guidelines for Japanese (ja) locale

6 participants