[Android] ScrollView - Setting SetClipChildren to false by kubaflo · Pull Request #26475 · dotnet/maui

kubaflo · 2024-12-09T12:54:43Z

Issues Fixed

Fixes #20922

<ScrollView>
    <Border HeightRequest="200"
            WidthRequest="200"
            AutomationId="Border"
            BackgroundColor="Red">
        <Border.Shadow>
            <Shadow Radius="20"
                    Brush="Gray"
                    Offset="1,50"/>
        </Border.Shadow>
    </Border>
</ScrollView>

Before	After

rmarinho · 2024-12-10T18:53:08Z

/azp run

azure-pipelines · 2024-12-10T18:53:29Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-01-10T08:08:27Z

/azp run

azure-pipelines · 2025-01-10T08:08:49Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull Request Overview

This PR fixes an issue where shadows on UI elements inside ScrollViews were being clipped on Android. The fix involves setting SetClipChildren(false) on the padding shim container to allow shadow effects to render outside the bounds of their parent container.

Adds SetClipChildren(false) to the padding shim in ScrollView handler for Android
Includes comprehensive UI test implementation to verify shadow rendering works correctly
Addresses the specific case where Grid shadows were not visible within ScrollViews

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File	Description
src/Core/src/Handlers/ScrollView/ScrollViewHandler.Android.cs	Adds SetClipChildren(false) to prevent shadow clipping in ScrollView
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20922.cs	NUnit test to verify shadow visibility in ScrollView
src/Controls/tests/TestCases.HostApp/Issues/Issue20922.cs	Host app test page with Grid shadow inside ScrollView

Copilot · 2025-08-11T22:52:35Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20922.cs

+		[Category(UITestCategories.ScrollView)]
+		public void ShadowShouldWork()
+		{
+			App.WaitForElement("Grid");


The test is waiting for an element with AutomationId "Grid" but the actual AutomationId in the HostApp is "Grid". While this matches, the test description mentions "Border" in the PR description example, but the actual implementation uses Grid. Ensure the AutomationIds are consistent between the test case and the HostApp implementation.

github-actions · 2026-03-16T21:47:05Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 26475

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 26475"

StephaneDelcroix · 2026-03-18T11:02:09Z

/azp run maui-pr-uitest, maui-pr-devicetests

azure-pipelines · 2026-03-18T11:02:25Z

Azure Pipelines successfully started running 1 pipeline(s).

StephaneDelcroix

Multi-Model Consensus Review -- Follow-up Note

Status: ✅ Approved & auto-merge enabled

This PR was approved and has auto-merge (squash) enabled. For completeness, here are the minor findings from our multi-model review:

🟡 MODERATE ScrollViewHandler.Android.cs:244 -- paddingShim.SetClipChildren(false) is applied unconditionally to all ScrollViews, not just those with shadows. This disables Android's display-list clipping optimization globally, increasing overdraw. Consider scoping to only apply when content has elevation/shadow in a future follow-up.

🟢 MINOR -- SetClipToPadding(false) may also be needed for complete shadow rendering near padded edges. And the outer MauiScrollView viewport may still clip overflow since only the inner paddingShim is addressed.

These are non-blocking observations for future consideration. The fix is a net improvement for the targeted shadow-clipping bug.

StephaneDelcroix

Multi-Model Consensus Review -- Follow-up Note

Status: ✅ Approved & auto-merge enabled

This PR was approved and has auto-merge (squash) enabled. For completeness, here are the minor findings from our multi-model review:

🟡 MODERATE ScrollViewHandler.Android.cs:244 -- paddingShim.SetClipChildren(false) is applied unconditionally to all ScrollViews, not just those with shadows. This disables Android's display-list clipping optimization globally, increasing overdraw. Consider scoping to only apply when content has elevation/shadow in a future follow-up.

🟢 MINOR -- SetClipToPadding(false) may also be needed for complete shadow rendering near padded edges. And the outer MauiScrollView viewport may still clip overflow since only the inner paddingShim is addressed.

These are non-blocking observations for future consideration. The fix is a net improvement for the targeted shadow-clipping bug.

jfversluis

Build errors and all kinds of unrelated files in this PR @kubaflo

dotnet-policy-service · 2026-03-19T09:49:59Z

Hi @@kubaflo. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

kubaflo · 2026-03-19T17:03:18Z

/azp run maui-pr-uitests

azure-pipelines · 2026-03-19T17:03:32Z

Azure Pipelines successfully started running 1 pipeline(s).

## Description Remove the "Are you waiting for the changes in this PR to be merged?" note from all Copilot instruction files. This note was previously required at the top of every PR description so users could find instructions on how to test PR artifacts. We now have a **dogfooding comment bot** that automatically posts testing instructions under each PR, making this manual note redundant. Copilot agents were still prepending this note to every PR description because it was hardcoded in: - `.github/copilot-instructions.md` (main instructions) - `.github/skills/pr-finalize/SKILL.md` (PR finalization skill) - `.github/skills/pr-finalize/references/complete-example.md` (example PR) ### Issues Fixed N/A — instruction cleanup only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kubaflo · 2026-03-20T12:41:19Z

/azp run maui-pr-uitests

azure-pipelines · 2026-03-20T12:41:31Z

Azure Pipelines successfully started running 1 pipeline(s).

The base branch was changed.

kubaflo · 2026-03-20T14:50:17Z

/azp run maui-pr-uitests

azure-pipelines · 2026-03-20T14:50:24Z

Command 'run-maui-pr-uitests' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

azure-pipelines · 2026-03-20T14:50:56Z

Azure Pipelines successfully started running 1 pipeline(s).

Address review feedback: - Only disable clipping when content has a shadow (avoids globally disabling Android's display-list clipping optimization) - Add SetClipToPadding(false) for complete shadow rendering near padded edges - Also disable clipping on the outer MauiScrollView viewport to prevent shadow overflow clipping Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

### Issues Fixed Fixes #20922 ``` <ScrollView> <Border HeightRequest="200" WidthRequest="200" AutomationId="Border" BackgroundColor="Red"> <Border.Shadow> <Shadow Radius="20" Brush="Gray" Offset="1,50"/> </Border.Shadow> </Border> </ScrollView> ``` |Before|After| |--|--| |<img src="https://github.com/user-attachments/assets/2d0e8e59-5b3e-4953-bc96-75658cd7555e" width="300px"/>|<img src="https://github.com/user-attachments/assets/3f31a65f-5cdc-4811-bbbe-f008af39f285" width="300px"/>| --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kubaflo requested a review from a team as a code owner December 9, 2024 12:54

kubaflo requested review from Eilon and jsuarezruiz December 9, 2024 12:54

dotnet-policy-service bot added the community ✨ Community Contribution label Dec 9, 2024

kubaflo added platform/android area-controls-scrollview ScrollView labels Dec 9, 2024

kubaflo requested a review from jfversluis as a code owner December 16, 2024 01:37

kubaflo force-pushed the fix-20922 branch from ac4a213 to 2be63bf Compare January 10, 2025 19:48

kubaflo force-pushed the fix-20922 branch from 2be63bf to fd27bee Compare March 30, 2025 23:15

kubaflo self-assigned this Mar 30, 2025

kubaflo force-pushed the fix-20922 branch from fd27bee to f9d2a05 Compare August 11, 2025 22:52

Copilot AI review requested due to automatic review settings August 11, 2025 22:52

Copilot AI reviewed Aug 11, 2025

View reviewed changes

kubaflo force-pushed the fix-20922 branch from f9d2a05 to 7f01e31 Compare January 16, 2026 11:06

kubaflo force-pushed the fix-20922 branch from 7f01e31 to 7fa7aec Compare March 16, 2026 21:46

StephaneDelcroix previously approved these changes Mar 18, 2026

View reviewed changes

StephaneDelcroix enabled auto-merge (squash) March 18, 2026 11:07

StephaneDelcroix disabled auto-merge March 18, 2026 11:08

StephaneDelcroix reviewed Mar 18, 2026

View reviewed changes

kubaflo changed the base branch from main to inflight/current March 18, 2026 14:03

jfversluis requested changes Mar 19, 2026

View reviewed changes

jfversluis added the s/pr-needs-author-input PR needs an update from the author label Mar 19, 2026

PureWeen force-pushed the inflight/current branch from 0bba31b to 627b389 Compare March 19, 2026 13:52

kubaflo force-pushed the fix-20922 branch from 7fa7aec to 205e6b6 Compare March 19, 2026 15:33

kubaflo changed the base branch from inflight/current to main March 20, 2026 14:49

kubaflo and others added 2 commits March 21, 2026 00:30

[Android] ScrollView - Setting SetClipChildren to false

7e65164

kubaflo force-pushed the fix-20922 branch from 2fc7d45 to 138d861 Compare March 20, 2026 23:30

snapshots updated

b17227b

kubaflo added the s/agent-fix-implemented PR author implemented the agent suggested fix label Mar 20, 2026

kubaflo changed the base branch from main to inflight/current March 20, 2026 23:46

kubaflo merged commit b88c706 into dotnet:inflight/current Mar 20, 2026
3 of 12 checks passed

Conversation

kubaflo commented Dec 9, 2024

Issues Fixed

Uh oh!

rmarinho commented Dec 10, 2024

Uh oh!

azure-pipelines bot commented Dec 10, 2024

Uh oh!

jsuarezruiz commented Jan 10, 2025

Uh oh!

azure-pipelines bot commented Jan 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephaneDelcroix commented Mar 18, 2026

Uh oh!

azure-pipelines bot commented Mar 18, 2026

Uh oh!

StephaneDelcroix left a comment

Choose a reason for hiding this comment

Multi-Model Consensus Review -- Follow-up Note

Status: ✅ Approved & auto-merge enabled

Uh oh!

StephaneDelcroix left a comment

Choose a reason for hiding this comment

Multi-Model Consensus Review -- Follow-up Note

Status: ✅ Approved & auto-merge enabled

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

dotnet-policy-service bot commented Mar 19, 2026

Uh oh!

kubaflo commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

kubaflo commented Mar 20, 2026

Uh oh!

azure-pipelines bot commented Mar 20, 2026

Uh oh!

kubaflo commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Mar 20, 2026

Uh oh!

azure-pipelines bot commented Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Mar 16, 2026 •

edited

Loading

kubaflo commented Mar 20, 2026 •

edited

Loading