[2025/03/24] Candidate - In Flight Branch#28560
Merged
Conversation
PureWeen
added
the
p/0
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR incorporates inflight fixes and enhancements primarily targeted at testing consistency for scale, rotation, and other UI properties across platforms, along with minor behavior adjustments in core controls such as Stepper and platform-specific handlers.
- Adds new unit tests for Scale, Rotation, and related properties to DatePicker, Image, CheckBox, Entry, Button, BoxView, Label, Editor, and CollectionView across Windows, Android, and iOS.
- Updates platform-specific implementations in TabbedPageManager, CollectionView handlers, CarouselViewControllers, and modifications in Stepper validation logic.
- Enhances cleanup and resource management in ItemsViewHandler for Windows.
Reviewed Changes
Copilot reviewed 113 out of 113 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.Windows.cs | New unit test to validate DatePicker Text and Icon colors under PointerOver state. |
| src/Controls/tests/DeviceTests/Elements/Image/ImageTests.Android.cs | Added tests to confirm ScaleX/ScaleY/Scale properties match native properties. |
| src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs | Added tests for Scale and Rotation properties; minor naming inconsistency observed. |
| src/Controls/tests/DeviceTests/Elements/CollectionView/... | Numerous tests added/updated for both Android and iOS to ensure collection view behaviors. |
| src/Controls/src/Core/Platform/Android/TabbedPageManager.cs | Refactored TabbedPageManager API to pass page context when applying icon color filters. |
| src/Controls/src/Core/Stepper/Stepper.cs | Adjusted bindable property validations to permit Maximum equal to Minimum. |
| src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs | Removed redundant TintColor assignment based on FontImageSource color. |
| src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs | Added additional cleanup for _formsEmptyView during disconnect. |
| Other files | Various updates to CarouselViewController implementations and minor style adjustments. |
Comments suppressed due to low confidence (2)
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs:34
- [nitpick] The variable name 'PlatformCheckBox' uses PascalCase unlike similar local variables in other tests (e.g. 'platformEntry', 'platformLabel'). Consider renaming it to 'platformCheckBox' for consistency.
var PlatformCheckBox = GetNativeCheckBox(handler);
src/Controls/src/Core/Stepper/Stepper.cs:15
- The validation change from '>' to '>=' allows Maximum to equal Minimum. Confirm that this behavior change is intentional as it alters the allowable input boundary.
validateValue: (bindable, value) => (double)value >= ((Stepper)bindable).Minimum,
mattleibow
added
the
area-infrastructure
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
force-pushed
the
inflight/candidate
branch
from
a9246ce to
5a4e1f1
Compare
Member
|
/rebase |
…Control (#27220) * fix code updated * updated failing ios ui test case images. * updated ui test images for mac and windows * resolving branch conflicts
…#27873) * Fixed Shadow not updated when Clipping a View with a shadow * FIxed shadow not updating with vlip * Updated code changes * Updated testcase image * Updated test case * updated test case image * Added pending snapshots
…ion - 15 (#27965) * enable the test case for all platforms * enable ScrollViewObjectDisposed.cs * updated the changes * modified * added the snapshot * added snapshot * modified changes * Update Issue17453.cs * modified Issue17453.cs
…ion - 19 (#28060) * Enable the product and Appium related Issues * Added snapshots * Updated Changes * Update Issue25193.cs
* Fixed Label Display on macOS and IOS When Padding is Applied * Optimized the fix * Added test case * Added Snapshot for android and iOS * Added snapshot for winUI and macOS, updated test sample
…s into device tests - 5 (#28193) * Test case added * Update LabelTests.iOS.cs * test case added * code changes * reverted changes * Update src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * handler code change * conflict code changes * flow direction test * Revert "flow direction test" This reverts commit 1f5c535. * Reverted changes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com>
…dows (#28367) * Fixed Using CollectionView.EmptyView results in an Exception on Windows * Test case written and fix slightly modified * Test case modified * Snap added for android and iOS * Test case modified * snap removed * Test case modified * Removed curly braces * Test case modified
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
…s into device tests - 7 (#28409) * Enabled the Shell and ObservableItemsSource for device test * Updated CollectionViewTests.Android.cs * Addressed the feedback * Removed three test cases from the CollectionView test * Corrected the misspelled words
* Make IShape in MauiCALayer a WeakReference * Added DeviceTest --------- Co-authored-by: Rain336 <rain336@live.de>
…erly to the Tab Icon (#26757) * Tab icon color fix * Test sample changes * Added snapshots * Added details * Added Mac snapshots * Removed unwanted parameters and modified the test sample * Committed the proper mac snap * Removed the unwanted issue list comments * Addressed the review concerns --------- Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
Remove ShapeableImageView Padding immediately after it is set in its onMeasure method to avoid double padding (ContentPadding + Padding).
…ollMode when collection modified (#26608) * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Commit for 25991 * Commit for testcase changes * Update CarouselViewController2.cs * commit for unwanted changes * commit for unwanted changes * commit for testcase removal * commit for refactor * commit for method name change * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Fix the test * Update Issue25991.cs with minor fixes and additions * Fix Issue25991 test assertions and string format * Commit for testcase failure * commit for testcase changes * commit for testcase changes * Create ItemShouldbeScrolledbasedOnGroupHeader.png * Delete ItemShouldbeScrolledbasedOnGroupHeader.png * Add check for empty ItemsSource in CarouselViewController2. * Fix item addition logic in Issue25991 test * Update issue comments in Issue8964.cs --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
… hovering over it. (#27147) * Fixed the Hovering issue of text and icon color in the DatePicker in windows. * Included the UI test sample and test case * Modified the test * Added Device Test --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
…28456) * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs * Update PropertyPropagationExtensions.cs
* Resaved Image For RadioButtonUpdateValueInserBorder * updated test case code --------- Co-authored-by: praveenkumarkarunanithi <praveenkumar.karunanithi@syncfusion.com>
* Support for Android * Added a UI Test
github-actions
bot
force-pushed
the
inflight/candidate
branch
from
0622a37 to
06e8924
Compare
Redth
approved these changes
Mar 28, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
This was referenced Apr 17, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Only PRs related to fixing this branch should be merge here
For more information about inflight process check
#28486