Skip to content

scripted_metric _agg parameter disappears if params are provided#27159

Merged
colings86 merged 9 commits intoelastic:masterfrom
reeselevine:scripted_metrix_fix
Nov 8, 2017
Merged

scripted_metric _agg parameter disappears if params are provided#27159
colings86 merged 9 commits intoelastic:masterfrom
reeselevine:scripted_metrix_fix

Conversation

@reeselevine
Copy link
Copy Markdown
Contributor

@reeselevine reeselevine commented Oct 28, 2017

A follow up to @consulthys's PR #19863, fixes the test so the build passes.
Closes: #19768

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Oct 28, 2017

Hi @reeselevine, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 28, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@reeselevine
Copy link
Copy Markdown
Contributor Author

reeselevine commented Oct 29, 2017

Hi @karmi I added the email I used in my commit to my Github profile, let me know if that worked. Thanks!

@javanna javanna requested a review from colings86 November 6, 2017 16:20
@colings86
Copy link
Copy Markdown
Contributor

colings86 commented Nov 7, 2017

jenkins test this please

@jasontedor
Merge branch 'master' into pr/27159
d4ad0de 
* master: (74 commits)
  Disable bwc tests in preparation of backporting #26931
  TemplateUpgradeService should only run on the master (#27294)
  Die with dignity while merging
  Fix profiling naming issues (#27133)
  Correctly encode warning headers
  Fixed references to Multi Index Syntax (#27283)
  Add an active Elasticsearch WordPress plugin link (#27279)
  Setting url parts as required to reflect the code base (#27263)
  keys in aggs percentiles need to be in quotes. (#26905)
  Align routing param type with search.json (#26958)
  Update to support bulk updates by query (#27172)
  Remove duplicated SnapshotStatus (#27276)
  add split index reference in indices.asciidoc
  Add ability to split shards (#26931)
  [Docs] Fix minor paragraph indentation error for multiple Indices params (#25535)
  Upgrade to Jackson 2.8.10 (#27230)
  Fix inconsistencies in the rest api specs for `tasks` (#27163)
  Adjust RestHighLevelClient method modifiers (#27238)
  Remove unused parameters in AnalysisRegistry (#27232)
  Add more information on `_failed_to_convert_` exception (#27034)
  ...
@jasontedor
Copy link
Copy Markdown
Member

jasontedor commented Nov 7, 2017

retest this please

@colings86
Copy link
Copy Markdown
Contributor

colings86 commented Nov 7, 2017

@reeselevine thanks for this PR, the change looks good and the build passes so I'll get this merged soon. Thank you for the contribution

@colings86 colings86 merged commit 74b1e7d into elastic:master Nov 8, 2017
colings86 pushed a commit that referenced this pull request Nov 8, 2017
@reeselevine @colings86
scripted_metric _agg parameter disappears if params are provided (#27159
f321c6d 
)

* Fixes #19768: scripted_metric _agg parameter disappears if params are provided

* Test case for #19768

* Compare boolean to false instead of negating it

* Added mocked script in ScriptedMetricIT

* Fix test in ScriptedMetricIT for implicit _agg map
jasontedor added a commit to glefloch/elasticsearch that referenced this pull request Nov 9, 2017
@jasontedor
Merge branch 'master' into pr/25003
2d36d41 
* master: (556 commits)
  Fix find remote when building BWC
  Remove colons from task and configuration names
  Add unreleased 5.6.5 version number
  testCreateSplitIndexToN: do not set `routing_partition_size` to >= `number_of_routing_shards`
  Snapshot/Restore: better handle incorrect chunk_size settings in FS repo (elastic#26844)
  Add limits for ngram and shingle settings (elastic#27211) (elastic#27318)
  Correct comment in index shard test
  Roll translog generation on primary promotion
  ObjectParser: Replace IllegalStateException with ParsingException (elastic#27302)
  scripted_metric _agg parameter disappears if params are provided (elastic#27159)
  Update discovery-ec2.asciidoc
  Update shrink's bwc version to 6.1.0 and enabled bwc tests
  Add limits for ngram and shingle settings (elastic#27211)
  Disable bwc tests in preparation of backporting elastic#26931
  TemplateUpgradeService should only run on the master (elastic#27294)
  Die with dignity while merging
  Fix profiling naming issues (elastic#27133)
  Correctly encode warning headers
  Fixed references to Multi Index Syntax (elastic#27283)
  Add an active Elasticsearch WordPress plugin link (elastic#27279)
  ...
jasontedor added a commit that referenced this pull request Nov 9, 2017
@jasontedor
Merge branch 'master' into ccr
2032881 
* master: (22 commits)
  Update Tika version to 1.15
  Aggregations: bucket_sort pipeline aggregation (#27152)
  Introduce templating support to timezone/locale in DateProcessor (#27089)
  Increase logging on qa:mixed-cluster tests
  Update to AWS SDK 1.11.223 (#27278)
  Improve error message for parse failures of completion fields (#27297)
  Ensure external refreshes will also refresh internal searcher to minimize segment creation (#27253)
  Remove optimisations to reuse objects when applying a new `ClusterState` (#27317)
  Decouple `ChannelFactory` from Tcp classes (#27286)
  Fix find remote when building BWC
  Remove colons from task and configuration names
  Add unreleased 5.6.5 version number
  testCreateSplitIndexToN: do not set `routing_partition_size` to >= `number_of_routing_shards`
  Snapshot/Restore: better handle incorrect chunk_size settings in FS repo (#26844)
  Add limits for ngram and shingle settings (#27211) (#27318)
  Correct comment in index shard test
  Roll translog generation on primary promotion
  ObjectParser: Replace IllegalStateException with ParsingException (#27302)
  scripted_metric _agg parameter disappears if params are provided (#27159)
  Update discovery-ec2.asciidoc
  ...
jasontedor added a commit that referenced this pull request Nov 9, 2017
@jasontedor
Merge branch '6.x' into ccr-6.x
536c2cc 
* 6.x:
  Update Tika version to 1.15
  Introduce templating support to timezone/locale in DateProcessor (#27089)
  Increase logging on qa:mixed-cluster tests
  Update to AWS SDK 1.11.223 (#27278)
  Improve error message for parse failures of completion fields (#27297)
  Remove optimisations to reuse objects when applying a new `ClusterState` (#27317)
  Decouple `ChannelFactory` from Tcp classes (#27286)
  Use PlainListenableActionFuture for CloseFuture (#26242)
  Fix find remote when building BWC
  Remove colons from task and configuration names
  Fix snapshot getting stuck in INIT state (#27214)
  Snapshot/Restore: better handle incorrect chunk_size settings in FS repo (#26844)
  Add unreleased 5.6.5 version number
  testCreateSplitIndexToN: do not set `routing_partition_size` to >= `number_of_routing_shards`
  Correct comment in index shard test
  Roll translog generation on primary promotion
  ObjectParser: Replace IllegalStateException with ParsingException (#27302)
  scripted_metric _agg parameter disappears if params are provided (#27159)
  Update discovery-ec2.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colings86 colings86 Awaiting requested review from colings86

Assignees

No one assigned

Labels

:Analytics/Aggregations Aggregations >bug v6.1.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scripted_metric _agg parameter disappears if params are provided

7 participants

@reeselevine @karmi @elasticmachine @colings86 @jasontedor @javanna @consulthys