Skip to content

Update to AWS SDK 1.11.223#27278

Merged
tlrx merged 1 commit intoelastic:masterfrom
tlrx:update-aws-sdk-to-1.11.223
Nov 9, 2017
Merged

Update to AWS SDK 1.11.223#27278
tlrx merged 1 commit intoelastic:masterfrom
tlrx:update-aws-sdk-to-1.11.223

Conversation

@tlrx
Copy link
Copy Markdown
Member

@tlrx tlrx commented Nov 6, 2017

This pull request updates the version of the AWS SDK dependency used by the repository-s3 plugin. The current version is old and many bugs have been fixed since 1.10.69.

jasontedor
jasontedor approved these changes Nov 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor
Copy link
Copy Markdown
Member

jasontedor commented Nov 6, 2017

If CI is happy, I'm happy.

@dadoonet
Copy link
Copy Markdown
Contributor

dadoonet commented Nov 6, 2017

Although not really the same purpose, should we close then #25552 in favor of this one?

@tlrx tlrx mentioned this pull request Nov 6, 2017
Merged
@tlrx tlrx merged commit 184dda9 into elastic:master Nov 9, 2017
tlrx added a commit that referenced this pull request Nov 9, 2017
@tlrx
Update to AWS SDK 1.11.223 (#27278)
b866e07
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Nov 9, 2017

Thanks @jasontedor ! I plan to backport this to 6.0.1 and 5.6.5 at the same time as #27280.

Although not really the same purpose, should we close then #25552 in favor of this one?

I don't think it must be closed. Instead it should be rebased and tests for ECS Task Roles must be added.

jasontedor added a commit that referenced this pull request Nov 9, 2017
@jasontedor
Merge branch 'master' into ccr
2032881 
* master: (22 commits)
  Update Tika version to 1.15
  Aggregations: bucket_sort pipeline aggregation (#27152)
  Introduce templating support to timezone/locale in DateProcessor (#27089)
  Increase logging on qa:mixed-cluster tests
  Update to AWS SDK 1.11.223 (#27278)
  Improve error message for parse failures of completion fields (#27297)
  Ensure external refreshes will also refresh internal searcher to minimize segment creation (#27253)
  Remove optimisations to reuse objects when applying a new `ClusterState` (#27317)
  Decouple `ChannelFactory` from Tcp classes (#27286)
  Fix find remote when building BWC
  Remove colons from task and configuration names
  Add unreleased 5.6.5 version number
  testCreateSplitIndexToN: do not set `routing_partition_size` to >= `number_of_routing_shards`
  Snapshot/Restore: better handle incorrect chunk_size settings in FS repo (#26844)
  Add limits for ngram and shingle settings (#27211) (#27318)
  Correct comment in index shard test
  Roll translog generation on primary promotion
  ObjectParser: Replace IllegalStateException with ParsingException (#27302)
  scripted_metric _agg parameter disappears if params are provided (#27159)
  Update discovery-ec2.asciidoc
  ...
jasontedor added a commit that referenced this pull request Nov 9, 2017
@jasontedor
Merge branch '6.x' into ccr-6.x
536c2cc 
* 6.x:
  Update Tika version to 1.15
  Introduce templating support to timezone/locale in DateProcessor (#27089)
  Increase logging on qa:mixed-cluster tests
  Update to AWS SDK 1.11.223 (#27278)
  Improve error message for parse failures of completion fields (#27297)
  Remove optimisations to reuse objects when applying a new `ClusterState` (#27317)
  Decouple `ChannelFactory` from Tcp classes (#27286)
  Use PlainListenableActionFuture for CloseFuture (#26242)
  Fix find remote when building BWC
  Remove colons from task and configuration names
  Fix snapshot getting stuck in INIT state (#27214)
  Snapshot/Restore: better handle incorrect chunk_size settings in FS repo (#26844)
  Add unreleased 5.6.5 version number
  testCreateSplitIndexToN: do not set `routing_partition_size` to >= `number_of_routing_shards`
  Correct comment in index shard test
  Roll translog generation on primary promotion
  ObjectParser: Replace IllegalStateException with ParsingException (#27302)
  scripted_metric _agg parameter disappears if params are provided (#27159)
  Update discovery-ec2.asciidoc
tlrx added a commit that referenced this pull request Nov 10, 2017
@tlrx
Update to AWS SDK 1.11.223 (#27278)
cebbc5f
@tlrx tlrx added the v6.0.1 label Nov 10, 2017
@jasontedor jasontedor mentioned this pull request Nov 13, 2017
Merged
@jasontedor
Copy link
Copy Markdown
Member

jasontedor commented Nov 13, 2017

@tlrx When you backport this to the 6.0 branch, can you also backport #27361? And if you backport this to the 5.6 branch, can you take #27361 there too?

@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Nov 13, 2017

@jasontedor I already backported it to 6.0 branch, but I'll take care to backport #27361 as well (and also on 5.6)

tlrx added a commit that referenced this pull request Nov 14, 2017
@tlrx
Update to AWS SDK 1.11.223 (#27278)
5a5c581
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Nov 14, 2017

This change has been backported to 5.6.5, 6.0.1, 6.1.0 and master.

@tlrx tlrx deleted the update-aws-sdk-to-1.11.223 branch November 14, 2017 10:29
@tlrx tlrx mentioned this pull request Jan 8, 2018
Closed
@clintongormley clintongormley added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Repository S3 labels Feb 14, 2018
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees

No one assigned

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement v5.6.5 v6.0.1 v6.1.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tlrx @jasontedor @dadoonet @clintongormley @colings86