Add support for indexed shape routing in geo_shape query by imotov · Pull Request #30760 · elastic/elasticsearch

imotov · 2018-05-21T18:09:26Z

Adds ability to specify the routing value for the indexed shape in the
geo_shape query.

Adds ability to specify the routing value for the indexed shape in the geo_shape query. Closes elastic#7663

elasticmachine · 2018-05-21T18:09:30Z

Pinging @elastic/es-search-aggs

nik9000 · 2018-05-21T18:18:52Z

server/src/test/java/org/elasticsearch/search/geo/GeoShapeIntegrationIT.java

+    /**
+     * Test that the indexed shape routing can be provided if it is required
+     */
+    public void testIndexShapeRoutine() throws Exception {


testIndexShape*Routing*?

nik9000 · 2018-05-21T18:20:17Z

server/src/main/java/org/elasticsearch/index/query/GeoShapeQueryBuilder.java

            indexedShapeType = in.readOptionalString();
            indexedShapeIndex = in.readOptionalString();
            indexedShapePath = in.readOptionalString();
+            if (in.getVersion().onOrAfter(Version.V_7_0_0_alpha1)) {


This should be 6.4.0, right?

Yes, eventually, after/during backport. If I make it 6.4.0 now, it will never pass BWC tests.

Cool. I figure the branch overrides like -Dtests.bwc.refspec.6.x= would be good for that sort of thing.

…ting-support-to-geo-shapes

imotov · 2018-05-22T20:23:58Z

retest this please

…ting-support-to-geo-shapes

* master: [DOCS] Splits auditing.asciidoc into smaller files Reintroduce mandatory http pipelining support (elastic#30820) Painless: Types Section Clean Up (elastic#30283) Add support for indexed shape routing in geo_shape query (elastic#30760) [test] java tests for archive packaging (elastic#30734) Revert "Make http pipelining support mandatory (elastic#30695)" (elastic#30813) [DOCS] Fix more edit URLs in Stack Overview (elastic#30704) Use correct cluster state version for node fault detection (elastic#30810) Change serialization version of doc-value fields. [DOCS] Fixes broken link for native realm [DOCS] Clarified audit.index.client.hosts (elastic#30797) [TEST] Don't expect acks when isolating nodes

* master: (25 commits) [DOCS] Splits auditing.asciidoc into smaller files Reintroduce mandatory http pipelining support (elastic#30820) Painless: Types Section Clean Up (elastic#30283) Add support for indexed shape routing in geo_shape query (elastic#30760) [test] java tests for archive packaging (elastic#30734) Revert "Make http pipelining support mandatory (elastic#30695)" (elastic#30813) [DOCS] Fix more edit URLs in Stack Overview (elastic#30704) Use correct cluster state version for node fault detection (elastic#30810) Change serialization version of doc-value fields. [DOCS] Fixes broken link for native realm [DOCS] Clarified audit.index.client.hosts (elastic#30797) [TEST] Don't expect acks when isolating nodes Add a `format` option to `docvalue_fields`. (elastic#29639) Fixes UpdateSettingsRequestStreamableTests mutate bug Mustes {p0=snapshot.get_repository/10_basic/*} YAML test Revert "Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled" Only allow x-pack metadata if all nodes are ready (elastic#30743) Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled Use original settings on full-cluster restart (elastic#30780) Only ack cluster state updates successfully applied on all nodes (elastic#30672) ...

Adds ability to specify the routing value for the indexed shape in the geo_shape query. Closes #7663

Aligns the routing value serialization version after backport of #30760

* 6.x: [DOCS] Fixes typos in security settings Add support for indexed shape routing in geo_shape query (#30760) [DOCS] Splits auditing.asciidoc into smaller files Painless: Types Section Clean Up (#30283) [test] java tests for archive packaging (#30734) Deprecate http.pipelining setting (#30786) [DOCS] Fix more edit URLs in Stack Overview (#30704) Use correct cluster state version for node fault detection (#30810) [DOCS] Fixes broken link for native realm [DOCS] Clarified audit.index.client.hosts (#30797) Change serialization version of doc-value fields. Add a `format` option to `docvalue_fields`. (#29639) [TEST] Don't expect acks when isolating nodes Fixes UpdateSettingsRequestStreamableTests mutate bug Revert "Add more yaml tests for get alias API (#29513)" Revert "Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled" Only allow x-pack metadata if all nodes are ready (#30743) Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled Use original settings on full-cluster restart (#30780) Only ack cluster state updates successfully applied on all nodes (#30672) Replace Request#setHeaders with addHeader (#30588) [TEST] remove endless wait in RestClientTests (#30776) QA: Add xpack tests to rolling upgrade (#30795) Add support for search templates to the high-level REST client. (#30473) Reduce CLI scripts to one-liners on Windows (#30772) Fold RestGetAllSettingsAction in RestGetSettingsAction (#30561) Add more yaml tests for get alias API (#29513) [Docs] Fix script-fields snippet execution (#30693) Convert FieldCapabilitiesResponse to a ToXContentObject. (#30182) Remove assert statements from field caps documentation. (#30601) Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (#30181) Add support for field capabilities to the high-level REST client. (#29664) [DOCS] Add SAML configuration information (#30548) [DOCS] Remove X-Pack references from SQL CLI (#30694) [Docs] Fix typo in circuit breaker docs (#29659) [Feature] Adding a char_group tokenizer (#24186) Increase the maximum number of filters that may be in the cache. (#30655) [Docs] Fix broken cross link in documentation Test: wait for netty threads in a JUnit ClassRule (#30763) [Security] Include an empty json object in an json array when FLS filters out all fields (#30709) [DOCS] fixed incorrect default [TEST] Wait for CS to be fully applied in testDeleteCreateInOneBulk Enable installing plugins from snapshots.elastic.co (#30765) Ignore empty completion input (#30713) Fix docs failure on language analyzers (#30722) [Docs] Fix inconsistencies in snapshot/restore doc (#30480) Add Delete Repository High Level REST API (#30666) Reduce CLI scripts to one-liners (#30759)

* master: [DOCS] Fixes typos in security settings Fix GeoShapeQueryBuilder serialization after backport [DOCS] Splits auditing.asciidoc into smaller files Reintroduce mandatory http pipelining support (#30820) Painless: Types Section Clean Up (#30283) Add support for indexed shape routing in geo_shape query (#30760) [test] java tests for archive packaging (#30734) Revert "Make http pipelining support mandatory (#30695)" (#30813) [DOCS] Fix more edit URLs in Stack Overview (#30704) Use correct cluster state version for node fault detection (#30810) Change serialization version of doc-value fields. [DOCS] Fixes broken link for native realm [DOCS] Clarified audit.index.client.hosts (#30797) [TEST] Don't expect acks when isolating nodes Add a `format` option to `docvalue_fields`. (#29639) Fixes UpdateSettingsRequestStreamableTests mutate bug Mustes {p0=snapshot.get_repository/10_basic/*} YAML test Revert "Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled" Only allow x-pack metadata if all nodes are ready (#30743) Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled Use original settings on full-cluster restart (#30780) Only ack cluster state updates successfully applied on all nodes (#30672) Expose Lucene's FeatureField. (#30618) Fix a grammatical error in the 'search types' documentation. Remove http pipelining from integration test case (#30788)

* es/ccr: (55 commits) [DOCS] Fixes typos in security settings Fix GeoShapeQueryBuilder serialization after backport [DOCS] Splits auditing.asciidoc into smaller files Reintroduce mandatory http pipelining support (elastic#30820) Painless: Types Section Clean Up (elastic#30283) Add support for indexed shape routing in geo_shape query (elastic#30760) [test] java tests for archive packaging (elastic#30734) Revert "Make http pipelining support mandatory (elastic#30695)" (elastic#30813) [DOCS] Fix more edit URLs in Stack Overview (elastic#30704) Use correct cluster state version for node fault detection (elastic#30810) Change serialization version of doc-value fields. [DOCS] Fixes broken link for native realm [DOCS] Clarified audit.index.client.hosts (elastic#30797) [TEST] Don't expect acks when isolating nodes Mute CorruptedFileIT in CCR Add a `format` option to `docvalue_fields`. (elastic#29639) Fixes UpdateSettingsRequestStreamableTests mutate bug Mustes {p0=snapshot.get_repository/10_basic/*} YAML test Revert "Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled" Only allow x-pack metadata if all nodes are ready (elastic#30743) ...

Add support for indexed shape routing in geo_shape query

0450560

Adds ability to specify the routing value for the indexed shape in the geo_shape query. Closes elastic#7663

imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v7.0.0 v6.4.0 labels May 21, 2018

imotov requested a review from colings86 May 21, 2018 18:09

nik9000 approved these changes May 21, 2018

View reviewed changes

imotov added 2 commits May 22, 2018 15:12

Fix the test name

d284af1

Merge remote-tracking branch 'elastic/master' into issue-7663-add-rou…

732f996

…ting-support-to-geo-shapes

Merge remote-tracking branch 'elastic/master' into issue-7663-add-rou…

7c9d25a

…ting-support-to-geo-shapes

imotov merged commit 4b69159 into elastic:master May 23, 2018

imotov added the backport pending label May 23, 2018

imotov added a commit that referenced this pull request May 23, 2018

Add support for indexed shape routing in geo_shape query (#30760)

89aa7bd

Adds ability to specify the routing value for the indexed shape in the geo_shape query. Closes #7663

imotov removed the backport pending label May 23, 2018

imotov added a commit that referenced this pull request May 23, 2018

Fix GeoShapeQueryBuilder serialization after backport

699153e

Aligns the routing value serialization version after backport of #30760

Mpdreamz mentioned this pull request Sep 25, 2018

[meta] 6.4.0 release elastic/elasticsearch-net#3397

Closed

89 tasks

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

imotov deleted the issue-7663-add-routing-support-to-geo-shapes branch May 1, 2020 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for indexed shape routing in geo_shape query#30760

Add support for indexed shape routing in geo_shape query#30760
imotov merged 4 commits intoelastic:masterfrom
imotov:issue-7663-add-routing-support-to-geo-shapes

imotov commented May 21, 2018

Uh oh!

elasticmachine commented May 21, 2018

Uh oh!

nik9000 May 21, 2018

Uh oh!

nik9000 May 21, 2018

Uh oh!

imotov May 21, 2018

Uh oh!

nik9000 May 21, 2018

Uh oh!

imotov commented May 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

imotov commented May 21, 2018

Uh oh!

elasticmachine commented May 21, 2018

Uh oh!

nik9000 May 21, 2018

Choose a reason for hiding this comment

Uh oh!

nik9000 May 21, 2018

Choose a reason for hiding this comment

Uh oh!

imotov May 21, 2018

Choose a reason for hiding this comment

Uh oh!

nik9000 May 21, 2018

Choose a reason for hiding this comment

Uh oh!

imotov commented May 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants