Skip to content

[DOC] Add watcher to the threadpool doc#73935

Merged
jrodewig merged 5 commits intoelastic:masterfrom
renshuki:watcher-threadpool-doc
Jun 16, 2021
Merged

[DOC] Add watcher to the threadpool doc#73935
jrodewig merged 5 commits intoelastic:masterfrom
renshuki:watcher-threadpool-doc

Conversation

@renshuki
Copy link
Copy Markdown
Contributor

@renshuki renshuki commented Jun 9, 2021

watcher is a relatively common threadpool and I think it would be beneficial to add it to the doc.

Based on:

elasticsearch/x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/Watcher.java

Lines 536 to 543 in 68817d7

static int getWatcherThreadPoolSize(final boolean isDataNode, final int allocatedProcessors) {
if (isDataNode) {
final long size = Math.max(Math.min(5 * allocatedProcessors, 50), allocatedProcessors);
return Math.toIntExact(size);
} else {
return 1;
}
}

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 9, 2021
@renshuki renshuki changed the title Add watcher to the threadpool doc [DOC] Add watcher to the threadpool doc Jun 9, 2021
@renshuki renshuki added the Team:Docs Meta label for docs team label Jun 9, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 9, 2021

Pinging @elastic/es-docs (Team:Docs)

jrodewig
jrodewig approved these changes Jun 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to incorporate a minor change. I'll wait for an engineer to approve before merging.

@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Jun 9, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 9, 2021

Pinging @elastic/es-core-features (Team:Core/Features)

@jrodewig jrodewig requested a review from joegallo June 9, 2021 11:35
@joegallo
Copy link
Copy Markdown
Contributor

joegallo commented Jun 10, 2021 •
edited
Loading

I'll review this one today, thanks for the heads up @jrodewig. (edit from the future: I hang my head in shame! This fell off my plate and then I forgot it. 😞)

joegallo added 3 commits June 16, 2021 10:46
@joegallo
Reword slightly
350cded 
Just trying to match more precisely the pattern of the previous
entries.
@joegallo
Reword all of these slightly
f391ac9 
The pattern went awry on all these -- see `management` where it's
"with a keep-alive of `5m` and a default maximum size of". Here we
lost the keep-alive phrase, so the 'and' should instead be a 'with'.
@joegallo
Merge branch 'master' into pull/73935
660392b
@joegallo joegallo requested a review from jrodewig June 16, 2021 14:49
joegallo
joegallo approved these changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some commits by way of review, so I'm 👍 now. @jrodewig would you mind re-reviewing?

jrodewig
jrodewig approved these changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @renshuki @joegallo.

@jrodewig jrodewig merged commit 0ea7cbd into elastic:master Jun 16, 2021
This was referenced Jun 16, 2021
Merged
Merged
jrodewig added a commit that referenced this pull request Jun 16, 2021
@jrodewig @joegallo @renshuki
[DOC] Add watcher to the threadpool doc (#73935) (#74187)
4cbd920 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Joe Gallo <joegallo@gmail.com>
Co-authored-by: François-Clément Brossard <renshuki@users.noreply.github.com>
jrodewig added a commit that referenced this pull request Jun 16, 2021
@jrodewig @joegallo @renshuki
[DOC] Add watcher to the threadpool doc (#73935) (#74189)
dd839f8 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Joe Gallo <joegallo@gmail.com>
Co-authored-by: François-Clément Brossard <renshuki@users.noreply.github.com>
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
Merge branch 'master' into custom
0df9b9f 
* master: (284 commits)
  [DOCS] Update central reporting image (elastic#74195)
  [DOCS] SQL: Document `null` handing for string functions (elastic#74201)
  Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196)
  [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194)
  Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198)
  Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114)
  [DOC] Add watcher to the threadpool doc (elastic#73935)
  [Rest Api Compatibility] Validate Query typed api (elastic#74171)
  Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144)
  Pin Alpine Linux version in Docker builds (elastic#74169)
  Fix clone API settings docs bug (elastic#74175)
  [ML] refactor internal datafeed management (elastic#74018)
  Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060)
  Fork the sending of file chunks during recovery (elastic#74164)
  RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840)
  Run CheckIndex on metadata index before loading (elastic#73239)
  Deprecate setting version on analyzers (elastic#74073)
  Add test with null transform id in stats request (elastic#74130)
  Order imports when reformatting (elastic#74059)
  Move deprecation code from xpack core to deprecation module. (elastic#74120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joegallo joegallo joegallo approved these changes

+1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed/Watcher >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v7.13.3 v7.14.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@renshuki @elasticmachine @joegallo @jrodewig @jakelandis @danhermann @elasticsearchmachine