Skip to content

[Transform] Replace missing transform id with _all wildcard#74130

Merged
przemekwitek merged 1 commit intoelastic:masterfrom
przemekwitek:transform_null_id_test
Jun 16, 2021
Merged

[Transform] Replace missing transform id with _all wildcard#74130
przemekwitek merged 1 commit intoelastic:masterfrom
przemekwitek:transform_null_id_test

Conversation

@przemekwitek
Copy link
Copy Markdown

@przemekwitek przemekwitek commented Jun 15, 2021

This PR fixes NPE that occurs when GetTransformStatsActionRequest is redirected to another node.
Before this PR, when transform_id in the request was missing, it was stored as null.
After this PR, missing transform_id is stored as _all, preventing NPE.

Fixes #74218

@przemekwitek przemekwitek force-pushed the transform_null_id_test branch 2 times, most recently from bee04b1 to ab0c45f Compare June 16, 2021 06:15
@przemekwitek przemekwitek changed the title Add test with null transform id in stats request [Transform] Replace absent transform id with _all wildcard Jun 16, 2021
@przemekwitek przemekwitek marked this pull request as ready for review June 16, 2021 06:20
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 16, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek force-pushed the transform_null_id_test branch from ab0c45f to 1d39892 Compare June 16, 2021 07:00
Copy link
Copy Markdown

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek changed the title [Transform] Replace absent transform id with _all wildcard [Transform] Replace missing transform id with _all wildcard Jun 16, 2021
@przemekwitek przemekwitek merged commit 4dbcc08 into elastic:master Jun 16, 2021
@przemekwitek przemekwitek deleted the transform_null_id_test branch June 16, 2021 08:29
przemekwitek pushed a commit to przemekwitek/elasticsearch that referenced this pull request Jun 16, 2021
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
* master: (284 commits)
  [DOCS] Update central reporting image (elastic#74195)
  [DOCS] SQL: Document `null` handing for string functions (elastic#74201)
  Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196)
  [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194)
  Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198)
  Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114)
  [DOC] Add watcher to the threadpool doc (elastic#73935)
  [Rest Api Compatibility] Validate Query typed api (elastic#74171)
  Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144)
  Pin Alpine Linux version in Docker builds (elastic#74169)
  Fix clone API settings docs bug (elastic#74175)
  [ML] refactor internal datafeed management (elastic#74018)
  Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060)
  Fork the sending of file chunks during recovery (elastic#74164)
  RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840)
  Run CheckIndex on metadata index before loading (elastic#73239)
  Deprecate setting version on analyzers (elastic#74073)
  Add test with null transform id in stats request (elastic#74130)
  Order imports when reformatting (elastic#74059)
  Move deprecation code from xpack core to deprecation module. (elastic#74120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Transform] Transform stats request doesn't work when transform id is missing.

4 participants