Skip to content

[Rest Api Compatibility] Validate Query typed api#74171

Merged
pgomulka merged 2 commits intoelastic:masterfrom
pgomulka:compat/validate_query
Jun 16, 2021
Merged

[Rest Api Compatibility] Validate Query typed api#74171
pgomulka merged 2 commits intoelastic:masterfrom
pgomulka:compat/validate_query

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Jun 16, 2021

Adds back typed endpoints for validate query api.
Previously removed in #46927

relates main meta issue #51816
relates types removal issue #54160

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Validate Query typed api
3fdc8de 
Adds back typed endpoints for validate query api.
Previously removed in elastic#46927

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka added the :Core/Infra/REST API REST infrastructure and utilities label Jun 16, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 16, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 16, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka added v8.0.0 and removed Team:Core/Infra Meta label for core/infra team labels Jun 16, 2021
@pgomulka pgomulka mentioned this pull request Jun 16, 2021
Closed
66 tasks
@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Jun 16, 2021 •
edited
Loading

@elasticmachine update branch

pgomulka
pgomulka commented Jun 16, 2021
View reviewed changes
.../src/test/java/org/elasticsearch/rest/action/admin/indices/RestValidateQueryActionTests.java

private static ThreadPool threadPool = new TestThreadPool(RestValidateQueryActionTests.class.getName());
private static NodeClient client = new NodeClient(Settings.EMPTY, threadPool);
private ThreadPool threadPool = new TestThreadPool(RestValidateQueryActionTests.class.getName());
Copy link
Copy Markdown
Contributor Author

@pgomulka pgomulka Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change the scope of threadPool and others otherwise the threadpool.ThreadContext is not correctly cleaned

romseygeek
romseygeek approved these changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 67b7fd4 into elastic:master Jun 16, 2021
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
Merge branch 'master' into custom
0df9b9f 
* master: (284 commits)
  [DOCS] Update central reporting image (elastic#74195)
  [DOCS] SQL: Document `null` handing for string functions (elastic#74201)
  Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196)
  [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194)
  Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198)
  Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114)
  [DOC] Add watcher to the threadpool doc (elastic#73935)
  [Rest Api Compatibility] Validate Query typed api (elastic#74171)
  Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144)
  Pin Alpine Linux version in Docker builds (elastic#74169)
  Fix clone API settings docs bug (elastic#74175)
  [ML] refactor internal datafeed management (elastic#74018)
  Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060)
  Fork the sending of file chunks during recovery (elastic#74164)
  RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840)
  Run CheckIndex on metadata index before loading (elastic#73239)
  Deprecate setting version on analyzers (elastic#74073)
  Add test with null transform id in stats request (elastic#74130)
  Order imports when reformatting (elastic#74059)
  Move deprecation code from xpack core to deprecation module. (elastic#74120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

@joegallo joegallo Awaiting requested review from joegallo

Assignees

No one assigned

Labels

:Core/Infra/REST API REST infrastructure and utilities >enhancement v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgomulka @elasticmachine @romseygeek @jakelandis