Unskip embeddables/adding_children suite#68111
Merged
Dosant merged 2 commits intoelastic:masterfrom Jun 8, 2020
Merged
Conversation
Contributor
Author
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/501/
|
Dosant
changed the title
Dosant
added
Feature:Embedding
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
spalger
approved these changes
Jun 5, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
Sure, if you think that might have caused the flakiness I'm alright with giving it another shot.
dmlemeshko
approved these changes
Jun 5, 2020
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Safe to assume it is no longer flaky?
100 green runs make it another chance :)
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jun 8, 2020
Giving it another chance *cross fingers* Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
Jun 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #58692
This test didn't fail in 114 runs:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/501/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/510/
Safe to assume it is no longer flaky?
My guess is that: #64789 could have caused flakiness, because we had 2 flouts opened -> 2 buttons.
In theory, cause of failure could have been that button was clicked in the first flyout, but then assert happen inside another.