Bump pdfmake package version#68395
Merged
jportner merged 2 commits intoelastic:masterfrom Jun 8, 2020
Merged
Conversation
jportner
added
chore
v8.0.0
release_note:skip
Member
|
Ack: will review on Monday FYI @elastic/kibana-reporting-services we are bumping your dependency for PDF creation. There’s a companion 6.8 PR linked above as well |
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jun 8, 2020
# Conflicts: # yarn.lock
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
jportner
added a commit
that referenced
this pull request
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several prior PRs have bumped the pdfmake package's patch version. This package includes quite a bit of transitive dependencies, and many of them have gotten stale.
In this PR, I removed the package and added it again. This ensures that transitive dependencies are updated accordingly.
Additionally, when this packaged was bumped in the past, it was never backported to Kibana's
6.8branch. I created a separate PR to bump it in that branch.Companion PR for
6.8: #68396