Skip to content

[ML] DFAnalytics results: ensure ml result fields are shown in data grid#68305

Merged
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-blank-ml-cols
Jun 8, 2020
Merged

[ML] DFAnalytics results: ensure ml result fields are shown in data grid#68305
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-blank-ml-cols

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jun 4, 2020

Summary

This PR fixes the issue of seeing blank ml subfield columns. ml.feature_importance and ml.top_classes are arrays of objects. The fields API used to create the columns incorrectly returns a path like ml.top_classes.class_name referencing the class_name property in the object in the array. This leads to blank column values as dot paths can only be in nested objects.

This PR fixes the issue by adding a ml.top_classes column and correctly displaying the array of objects as the values. It also hides the blank path columns by default.

This PR also ensures ml.feature_importance column shows up correctly.

ml.top_classes

image

ml.feature_importance

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner June 4, 2020 19:24
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jun 4, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 4, 2020

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson reviewed Jun 5, 2020
View reviewed changes
x-pack/plugins/ml/public/application/components/data_grid/common.ts Outdated
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove the ml.top_classes and ml.feature_importance leaf node fields from the data grid column picker modal e.g. ml.top_classes.class_name? Ideally we shouldn't let the user select the leaf nodes for display in the table as those columns will be blank:

image

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-blank-ml-cols branch from e17963c to 3324d71 Compare June 5, 2020 14:03
@alvarezmelissa87
Copy link
Copy Markdown
Contributor Author

alvarezmelissa87 commented Jun 5, 2020 •
edited
Loading

The PR that removed the ml.feature_importance column went into 7.8 (https://github.com/elastic/kibana/pull/63447/files#diff-316267b1bf7d7615f8ead6265c17cedaL276) so this may need to go into 7.8.

The removal of the ml.top_classes and ml.feature_importance leaf node fields will be done in a follow up.

cc @peteharverson, @walterra

@alvarezmelissa87 alvarezmelissa87 requested review from walterra and removed request for qn895 June 5, 2020 19:19
peteharverson
peteharverson approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Happy for the removal of the ml.top_classes and ml.feature_importance leaf node fields from the column picker to be done in a follow-up.

@peteharverson peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Jun 8, 2020
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-blank-ml-cols branch from 3324d71 to 000d61b Compare June 8, 2020 13:27
walterra
walterra approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

jgowdyelastic
jgowdyelastic approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 8, 2020

💚 Build Succeeded

History

  • 💚 Build #52068 succeeded 3324d714a50061218c098fd5c382932935474f8c
  • 💚 Build #51911 succeeded e17963c4709b79f2c2d55b01d40d1ff8c03c1223

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit e2f11e9 into elastic:master Jun 8, 2020
This was referenced Jun 8, 2020
Merged
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Jun 8, 2020
@alvarezmelissa87
[ML] DFAnalytics results: ensure ml result fields are shown in data g…
4ff19c8 
…rid (elastic#68305)

* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Jun 8, 2020
@alvarezmelissa87
[ML] DFAnalytics results: ensure ml result fields are shown in data g…
df52af9 
…rid (elastic#68305)

* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-blank-ml-cols branch June 8, 2020 15:25
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
445710f 
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
alvarezmelissa87 added a commit that referenced this pull request Jun 8, 2020
@alvarezmelissa87
[ML] DFAnalytics results: ensure ml result fields are shown in data g…
b01fce9 
…rid (#68305) (#68528)

* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
alvarezmelissa87 added a commit that referenced this pull request Jun 8, 2020
@alvarezmelissa87
[ML] DFAnalytics results: ensure ml result fields are shown in data g…
68d9293 
…rid (#68305) (#68529)

* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels

Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alvarezmelissa87 @elasticmachine @kibanamachine @walterra @peteharverson @jgowdyelastic