Refactor: JsErrorHandler: Rename JsErrorHandlingFunc -> OnJsError#43985
Closed
RSNara wants to merge 7 commits intofacebook:mainfrom
Closed
Refactor: JsErrorHandler: Rename JsErrorHandlingFunc -> OnJsError#43985RSNara wants to merge 7 commits intofacebook:mainfrom
RSNara wants to merge 7 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55563580 |
…acebook#43952) Summary: getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering. This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle. I filed a task for the investigation to see if there's any problems. And added it to the code in this diff. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547899
…3953) Summary: RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905
…dantly (facebook#43954) Summary: Now, all the defaulting is in RuntimeScheduler.h. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547900
…ed_ptr (facebook#43955) Summary: Just makes it easier to pass around JsErrorHandler. We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler. Changelog: [internal] Reviewed By: cipolleschi Differential Revision: D55547898
…orHandler (facebook#43956) Summary: I think we should try to centralize all things js error handling related inside JsErrorHandler. So, I moved this bool into JsErrorHandler. This makes ReactInstance easier to understand: it removes one member variable from ReactInstance. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547897
…alError (facebook#43957) Summary: Right now, JsErrorHandler is only used to handle fatal exceptions. So, let's just scope handleJsError down to handleFatalError. Changelog: [General][Breaking] - JsErrorHandler: Rename handleJsError to handleFatalError Reviewed By: cortinico Differential Revision: D55547901
…cebook#43985) Summary: This is just personal preference. The name "OnJsError" makes the intent of the abstraction clear: an instance of OnJsError is a function that gets called when a js error is caught. The name "JsErrorHandlingFunc" is not as good. Changelog: [General][Breaking] - JsErrorHandler: Rename JsErrorHandlingFunc to OnJsError Reviewed By: christophpurrer Differential Revision: D55563580
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55563580 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
…sError (facebook#43985) Summary: This is just personal preference. The name "OnJsError" makes the intent of the abstraction clear: an instance of OnJsError is a function that gets called when a js error is caught. The name "JsErrorHandlingFunc" is not as good. Changelog: [General][Breaking] - JsErrorHandler: Rename JsErrorHandlingFunc to OnJsError Reviewed By: christophpurrer Differential Revision: D55563580
Base commit: f77d028 |
Contributor
|
This pull request has been merged in 2e3f226. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is just personal preference.
The name "OnJsError" makes the intent of the abstraction clear: an instance of OnJsError is a function that gets called when a js error is caught.
The name "JsErrorHandlingFunc" is not as good.
Changelog: [General][Breaking] - JsErrorHandler: Rename JsErrorHandlingFunc to OnJsError
Reviewed By: christophpurrer
Differential Revision: D55563580