fix(deletions): Remove unnecessary skip_models check in Group deletion#108448
Merged
fix(deletions): Remove unnecessary skip_models check in Group deletion#108448
Conversation
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Feb 18, 2026
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
#108448) `similarity` is a module, not a model, so it would never appear in skip_models. The check was always truthy and thus dead code.
1 task
kcons
added a commit
that referenced
this pull request
Feb 23, 2026
#108606) strict_equality occasionally seems a bit picky, but it flags nonsense comparisons that can be tricky to identify otherwise. On average, it seems to make us safer and more honest without too much cost, and this in turn makes us able to move faster. See also: * #108478 * #108466 * #108462 * #108450 * #108448 * #108578
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
#108448) `similarity` is a module, not a model, so it would never appear in skip_models. The check was always truthy and thus dead code.
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
#108606) strict_equality occasionally seems a bit picky, but it flags nonsense comparisons that can be tricky to identify otherwise. On average, it seems to make us safer and more honest without too much cost, and this in turn makes us able to move faster. See also: * #108478 * #108466 * #108462 * #108450 * #108448 * #108578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similarityis a module, not a model, so it would never appear in skip_models.The check was always truthy and thus dead code.