Skip to content

fix(issues): Remove broken scope tag#108450

Merged
kcons merged 1 commit intomasterfrom
kcons/phase3
Feb 19, 2026
Merged

fix(issues): Remove broken scope tag#108450
kcons merged 1 commit intomasterfrom
kcons/phase3

Conversation

@kcons
Copy link
Member

@kcons kcons commented Feb 18, 2026

The value of stacktrace_link.empty_root hasn't been reliably accurate since it was added in 2024.
We could figure out which _root field to use and fix it, but given that it has been wrong this long, it seems
this tag is unnecessary and can be removed.

@kcons kcons requested review from a team as code owners February 18, 2026 17:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 18, 2026
@kcons kcons merged commit bf3fc5e into master Feb 19, 2026
78 checks passed
@kcons kcons deleted the kcons/phase3 branch February 19, 2026 20:03
JonasBa pushed a commit that referenced this pull request Feb 19, 2026
The value of stacktrace_link.empty_root hasn't been reliably accurate
since it was added in 2024.
We could figure out which _root field to use and fix it, but given that
it has been wrong this long, it seems
this tag is unnecessary and can be removed.
kcons added a commit that referenced this pull request Feb 23, 2026
#108606)

strict_equality occasionally seems a bit picky, but it flags nonsense
comparisons that can be tricky to identify otherwise.
On average, it seems to make us safer and more honest without too much
cost, and this in turn makes us able to move faster.

See also:
 * #108478
 * #108466
 * #108462
 * #108450
 * #108448
 * #108578
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
The value of stacktrace_link.empty_root hasn't been reliably accurate
since it was added in 2024.
We could figure out which _root field to use and fix it, but given that
it has been wrong this long, it seems
this tag is unnecessary and can be removed.
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
#108606)

strict_equality occasionally seems a bit picky, but it flags nonsense
comparisons that can be tricky to identify otherwise.
On average, it seems to make us safer and more honest without too much
cost, and this in turn makes us able to move faster.

See also:
 * #108478
 * #108466
 * #108462
 * #108450
 * #108448
 * #108578
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants