fix(workflow_engine): Fix integration_id type mismatch in action translator#108462
Merged
fix(workflow_engine): Fix integration_id type mismatch in action translator#108462
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
ceorourke
approved these changes
Feb 19, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
Combining ActionType and Action.type sounds like a good follow up 👍
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…slator (#108462) The BaseActionTranslator.integration_id property was annotated as returning int | None but actually returned str | None from the action dict. Fix the property to actually return int, and add refresh_from_db() in tests so the assertion operates on DB-coerced types. Unclear this was an actual misbehavior in prod code due to type coercion, but better to be verifiably correct. Also, Action.Type and ActionType aren't the same, despite having identical values. Made it consistent, though we should probably go back and consider whether we need two identical enums.
1 task
kcons
added a commit
that referenced
this pull request
Feb 23, 2026
#108606) strict_equality occasionally seems a bit picky, but it flags nonsense comparisons that can be tricky to identify otherwise. On average, it seems to make us safer and more honest without too much cost, and this in turn makes us able to move faster. See also: * #108478 * #108466 * #108462 * #108450 * #108448 * #108578
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…slator (#108462) The BaseActionTranslator.integration_id property was annotated as returning int | None but actually returned str | None from the action dict. Fix the property to actually return int, and add refresh_from_db() in tests so the assertion operates on DB-coerced types. Unclear this was an actual misbehavior in prod code due to type coercion, but better to be verifiably correct. Also, Action.Type and ActionType aren't the same, despite having identical values. Made it consistent, though we should probably go back and consider whether we need two identical enums.
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
#108606) strict_equality occasionally seems a bit picky, but it flags nonsense comparisons that can be tricky to identify otherwise. On average, it seems to make us safer and more honest without too much cost, and this in turn makes us able to move faster. See also: * #108478 * #108466 * #108462 * #108450 * #108448 * #108578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BaseActionTranslator.integration_id property was annotated as returning int | None but actually returned str | None from the action dict. Fix the property to actually return int, and add refresh_from_db() in tests so the assertion operates on DB-coerced types.
Unclear this was an actual misbehavior in prod code due to type coercion, but better to be verifiably correct.
Also, Action.Type and ActionType aren't the same, despite having identical values. Made it consistent, though
we should probably go back and consider whether we need two identical enums.