Skip to content

ref(core): button busy state and form SubmitButton UX#109869

Merged
TkDodo merged 6 commits intomasterfrom
tkdodo/feat/de-980-submitbuttom-ux
Mar 4, 2026
Merged

ref(core): button busy state and form SubmitButton UX#109869
TkDodo merged 6 commits intomasterfrom
tkdodo/feat/de-980-submitbuttom-ux

Conversation

@TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Mar 4, 2026

before:

Screenshot 2026-03-04 at 14 59 32

after:

Screenshot 2026-03-04 at 14 58 53

the width of the button will not change when we show the spinner, as the text is still there (just hidden) and we overlay the spinner by using the same grid area.

also, <form.SubmitButton> now assigns busy when the form is submitting and now longer disables when equal to defaultValues.

@linear
Copy link

linear bot commented Mar 4, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 4, 2026
@TkDodo TkDodo marked this pull request as ready for review March 4, 2026 14:11
@TkDodo TkDodo requested a review from a team as a code owner March 4, 2026 14:11
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@TkDodo TkDodo enabled auto-merge (squash) March 4, 2026 17:34
@TkDodo TkDodo merged commit 2ff37ee into master Mar 4, 2026
60 checks passed
@TkDodo TkDodo deleted the tkdodo/feat/de-980-submitbuttom-ux branch March 4, 2026 17:41
natemoo-re added a commit that referenced this pull request Mar 4, 2026
TkDodo added a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants