Revert "ref(core): button busy state and form SubmitButton UX"#109891
Revert "ref(core): button busy state and form SubmitButton UX"#109891natemoo-re merged 1 commit intomasterfrom
Conversation
This reverts commit 2ff37ee.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return ( | ||
| <form.Subscribe selector={state => state.isSubmitting}> | ||
| {isSubmitting => ( | ||
| <form.Subscribe selector={state => state.isSubmitting || state.isDefaultValue}> |
There was a problem hiding this comment.
Form state isDefaultValue property doesn't exist at form level
Medium Severity
The form.Subscribe selector accesses state.isDefaultValue, but isDefaultValue is a field-level metadata property (field.state.meta.isDefaultValue) in TanStack Form, not a form-level state property. On the FormState object, isDefaultValue is undefined, so the expression state.isSubmitting || state.isDefaultValue effectively reduces to just state.isSubmitting. The apparent intent — disabling the submit button when form values haven't changed from defaults — is silently non-functional.
2 participants
Reverts #109869