ref(core): button busy state and form SubmitButton UX#109934
Conversation
) This reverts commit ea5a376.
github-actions
bot
added
the
Scope: Frontend
| ${StyledTag} { | ||
| border-radius: ${p => p.theme.radius.full}; | ||
| } |
There was a problem hiding this comment.
note: we only want to change the border-radius when the StyledTag is used as the button trigger, as it’s also used as dropdown elements, where we want the normal radius:
| const StyledButton = styled(Button)` | ||
| width: 100%; | ||
| > span { | ||
| > span > span { |
There was a problem hiding this comment.
note: this component is only used in the old issues detail UI, which is no longer shown at all:
sentry/static/app/views/issueDetails/utils.tsx
Lines 279 to 283 in b2493a6
so it’s pretty much irrelevant, but technically correct.
| const StyledAssigneeBadge = styled(AssigneeBadge)` | ||
| border-radius: ${p => p.theme.radius.full}; | ||
| `; | ||
|
|
||
| const StyledTrigger = styled(OverlayTrigger.Button)` | ||
| font-weight: ${p => p.theme.font.weight.sans.regular}; | ||
| border: none; | ||
| padding: 0; | ||
| height: unset; | ||
| border-radius: 20px; | ||
| box-shadow: none; | ||
|
|
||
| > span > div { | ||
| border-radius: 20px; | ||
| } | ||
| border-radius: ${p => p.theme.radius.full}; |
There was a problem hiding this comment.
a lot of the stylings were unnecessary. I’m now changing the radius on the AssigneeBadge directly, which means I had to add className props to it to forward it correctly.
| const DropdownButton = styled(Button)` | ||
| font-weight: ${p => p.theme.font.weight.sans.regular}; | ||
| border: none; | ||
| padding: 0; | ||
| height: unset; | ||
| border-radius: 20px; | ||
| box-shadow: none; | ||
|
|
||
| > span > div { | ||
| border-radius: 20px; | ||
| } | ||
| `; | ||
|
|
There was a problem hiding this comment.
I removed all styles that didn’t yield any changes. I guess there are overrides that are leftovers from UI1
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
Nice style cleanup and good use of the primitives!
|
PR reverted: 72228d7 |
This reverts commit 978468b. Co-authored-by: JonasBa <9317857+JonasBa@users.noreply.github.com>
…)" This reverts commit 72228d7.
3 participants
second attempt of #109869, which was reverted by #109891