fix: add version string checking#2314
Conversation
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request adds version string validation to ensure release tags are valid semantic versions. The changes focus on improving input validation and error handling for version strings used in the deployment process.
- Adds semver validation for release tags to prevent invalid version strings from being processed
- Automatically prefixes version strings with 'v' if not already present
- Includes a minor code style fix for quote consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/commands/relay.ts | Minor quote style fix from backticks to single quotes |
| src/commands/node/tasks.ts | Adds version validation and automatic 'v' prefix for release tags |
| src/commands/node/configs.ts | Adds semver validation check for release tags |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
E2E Test Report 19 files ±0 135 suites ±0 1h 54m 43s ⏱️ + 1m 41s Results for commit b8026a3. ± Comparison against base commit dac31bb. This pull request removes 1 test. |
E2E Test Report 20 files + 1 138 suites +5 2h 9m 32s ⏱️ - 7m 24s Results for commit fc7e0fe. ± Comparison against base commit 1e4484e. This pull request removes 1 and adds 14 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
we need to ensure that anytime a version is passed in by the user, that we either add or remove the 'v' as needed based on whether it is needed for a helm chart, image, or consensus node version.
I only see the CN version check. But, I expected to see a check for passing in the helm chart versions or docker image as well
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
## [0.42.0](v0.41.0...v0.42.0) (2025-08-11) ### Features * add flag to private key ([#2356](#2356)) ([dc9c1d7](dc9c1d7)) * **cli:** implement solo quick start single destroy ([#2424](#2424)) ([5979db5](5979db5)) * create accounts with predefined keys on quick-start ([#2303](#2303)) ([0d5a0b0](0d5a0b0)) * helm dependency manager prefers global installation ([#2308](#2308)) ([9768ae0](9768ae0)) * update command flags and ECDSA key documents ([#2417](#2417)) ([246df6f](246df6f)) * updated smoke test help to debug intermittent failure ([#2420](#2420)) ([12a96b4](12a96b4)) ### Bug Fixes * add support for latest version of block node v0.15.0 ([#2391](#2391)) ([66d9f90](66d9f90)) * add version string checking ([#2314](#2314)) ([d790ca0](d790ca0)) * address issues for solo node add/update/delete when using separate subcommands ([#2398](#2398)) ([b1ea909](b1ea909)) * bump CN to v0.63.9, MN to v0.134, Relay to v0.69.3, BN to v0.14.0, Solo chart to v0.54.5 ([#2322](#2322)) ([e12938f](e12938f)) * bump explorer to v25.1.1 ([#2403](#2403)) ([bfae543](bfae543)) * bump relay version and fix some tests ([#2385](#2385)) ([c2f4bab](c2f4bab)) * correct service name in port-forward command for Mirror Node REST Java API ([#2396](#2396)) ([6847713](6847713)) * do not assign mask value to default value for data sensitive flags ([#2401](#2401)) ([ce96ad9](ce96ad9)) * handle optional adminKey flag safely in context configuration ([#2365](#2365)) ([8b20668](8b20668)) * remove logs of 'argv' and 'context.config' ([#2378](#2378)) ([a4d4e36](a4d4e36)) * remove unnecessary node logs from migration test workflow ([#2400](#2400)) ([43a53fc](43a53fc)) * solo quick-start single deploy failure during network setup ([#2369](#2369)) ([2f12c17](2f12c17)) * update post freeze CN source directory for application.properties ([#2397](#2397)) ([9752f9d](9752f9d))
|
🎉 This PR is included in version 0.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues
vprefix, it fails #2310Pull request (PR) checklist
package.jsonchanges have been explained to and approved by a repository managerTesting
The following manual testing was done:
The following was not tested:
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: