Skip to content

fix: remove logs of 'argv' and 'context.config'#2378

Merged
jeromy-cannon merged 1 commit intomainfrom
2377-chore-remove-logs-of-contextconfig
Jul 30, 2025
Merged

fix: remove logs of 'argv' and 'context.config'#2378
jeromy-cannon merged 1 commit intomainfrom
2377-chore-remove-logs-of-contextconfig

Conversation

@jan-milenkov
Copy link
Copy Markdown
Contributor

Description

Regex used: logger(?=[^\n]*\b(?:argv|config)\b)

Related Issues

Signed-off-by: Zhan Milenkov <instamenta@abv.bg>
@jan-milenkov jan-milenkov self-assigned this Jul 30, 2025
@jan-milenkov jan-milenkov requested a review from a team as a code owner July 30, 2025 16:05
@jan-milenkov jan-milenkov linked an issue Jul 30, 2025 that may be closed by this pull request
@jan-milenkov jan-milenkov added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jul 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a754f88. ± Comparison against base commit 61b6376.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results - Windows

  1 files  ±0  175 suites  ±0   4s ⏱️ +2s
492 tests ±0  492 ✅ ±0  0 💤 ±0  0 ❌ ±0 
496 runs  ±0  496 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a754f88. ± Comparison against base commit 61b6376.

@jeromy-cannon jeromy-cannon added PR: Ready to Merge A pull request that is ready to merge. and removed PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jul 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Report

 20 files  ±0  139 suites  ±0   2h 8m 10s ⏱️ + 1m 25s
379 tests ±0  379 ✅ ±0  0 💤 ±0  0 ❌ ±0 
392 runs  ±0  392 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a754f88. ± Comparison against base commit 61b6376.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Report

 20 files  ±0  139 suites  ±0   2h 8m 10s ⏱️ + 1m 25s
379 tests ±0  379 ✅ ±0  0 💤 ±0  0 ❌ ±0 
392 runs  ±0  392 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a754f88. ± Comparison against base commit 61b6376.

@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61b6376) 41272 35193 85.27%
Head commit (a754f88) 41235 (-37) 35172 (-21) 85.30% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2378) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jeromy-cannon jeromy-cannon merged commit a4d4e36 into main Jul 30, 2025
71 of 72 checks passed
@jeromy-cannon jeromy-cannon deleted the 2377-chore-remove-logs-of-contextconfig branch July 30, 2025 20:30
swirlds-automation added a commit that referenced this pull request Aug 11, 2025
## [0.42.0](v0.41.0...v0.42.0) (2025-08-11)

### Features

* add flag to private key ([#2356](#2356)) ([dc9c1d7](dc9c1d7))
* **cli:** implement solo quick start single destroy ([#2424](#2424)) ([5979db5](5979db5))
* create accounts with predefined keys on quick-start ([#2303](#2303)) ([0d5a0b0](0d5a0b0))
* helm dependency manager prefers global installation ([#2308](#2308)) ([9768ae0](9768ae0))
* update command flags and ECDSA key documents ([#2417](#2417)) ([246df6f](246df6f))
* updated smoke test help to debug intermittent failure ([#2420](#2420)) ([12a96b4](12a96b4))

### Bug Fixes

* add support for latest version of block node v0.15.0 ([#2391](#2391)) ([66d9f90](66d9f90))
* add version string checking ([#2314](#2314)) ([d790ca0](d790ca0))
* address issues for solo node add/update/delete when using separate subcommands ([#2398](#2398)) ([b1ea909](b1ea909))
* bump CN to v0.63.9, MN to v0.134, Relay to v0.69.3, BN to v0.14.0, Solo chart to v0.54.5 ([#2322](#2322)) ([e12938f](e12938f))
* bump explorer to v25.1.1 ([#2403](#2403)) ([bfae543](bfae543))
* bump relay version and fix some tests ([#2385](#2385)) ([c2f4bab](c2f4bab))
* correct service name in port-forward command for Mirror Node REST Java API ([#2396](#2396)) ([6847713](6847713))
* do not assign mask value to default value for data sensitive flags ([#2401](#2401)) ([ce96ad9](ce96ad9))
* handle optional adminKey flag safely in context configuration ([#2365](#2365)) ([8b20668](8b20668))
* remove logs of 'argv' and 'context.config' ([#2378](#2378)) ([a4d4e36](a4d4e36))
* remove unnecessary node logs from migration test workflow ([#2400](#2400)) ([43a53fc](43a53fc))
* solo quick-start single deploy failure during network setup ([#2369](#2369)) ([2f12c17](2f12c17))
* update post freeze CN source directory for application.properties ([#2397](#2397)) ([9752f9d](9752f9d))
@swirlds-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Ready to Merge A pull request that is ready to merge. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove logs of context.config

3 participants