Skip to content

feat: add flag to private key#2356

Merged
jeromy-cannon merged 1 commit intomainfrom
02354-D-display-privakte-key
Jul 25, 2025
Merged

feat: add flag to private key#2356
jeromy-cannon merged 1 commit intomainfrom
02354-D-display-privakte-key

Conversation

@JeffreyDallas
Copy link
Copy Markdown
Contributor

Description

This pull request changes the following:

  • Add flag to allow user to show private key during account create

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested a review from a team as a code owner July 25, 2025 05:37
@JeffreyDallas JeffreyDallas self-assigned this Jul 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3d3f20c. ± Comparison against base commit d790ca0.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results - Windows

  1 files  ±0  175 suites  ±0   3s ⏱️ -1s
492 tests ±0  492 ✅ ±0  0 💤 ±0  0 ❌ ±0 
496 runs  ±0  496 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3d3f20c. ± Comparison against base commit d790ca0.

@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Report

 20 files  ±0  138 suites  ±0   2h 7m 17s ⏱️ -30s
377 tests ±0  377 ✅ ±0  0 💤 ±0  0 ❌ ±0 
390 runs  ±0  390 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3d3f20c. ± Comparison against base commit d790ca0.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Report

 20 files  ±0  138 suites  ±0   2h 7m 17s ⏱️ -30s
377 tests ±0  377 ✅ ±0  0 💤 ±0  0 ❌ ±0 
390 runs  ±0  390 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3d3f20c. ± Comparison against base commit d790ca0.

@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d790ca0) 40938 34796 85.00%
Head commit (3d3f20c) 40943 (+5) 34801 (+5) 85.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2356) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jan-milenkov jan-milenkov added the PR: Needs Manager Approval A pull request that needs review from a manager. label Jul 25, 2025
@jeromy-cannon jeromy-cannon merged commit dc9c1d7 into main Jul 25, 2025
71 of 72 checks passed
@jeromy-cannon jeromy-cannon deleted the 02354-D-display-privakte-key branch July 25, 2025 15:17
swirlds-automation added a commit that referenced this pull request Aug 11, 2025
## [0.42.0](v0.41.0...v0.42.0) (2025-08-11)

### Features

* add flag to private key ([#2356](#2356)) ([dc9c1d7](dc9c1d7))
* **cli:** implement solo quick start single destroy ([#2424](#2424)) ([5979db5](5979db5))
* create accounts with predefined keys on quick-start ([#2303](#2303)) ([0d5a0b0](0d5a0b0))
* helm dependency manager prefers global installation ([#2308](#2308)) ([9768ae0](9768ae0))
* update command flags and ECDSA key documents ([#2417](#2417)) ([246df6f](246df6f))
* updated smoke test help to debug intermittent failure ([#2420](#2420)) ([12a96b4](12a96b4))

### Bug Fixes

* add support for latest version of block node v0.15.0 ([#2391](#2391)) ([66d9f90](66d9f90))
* add version string checking ([#2314](#2314)) ([d790ca0](d790ca0))
* address issues for solo node add/update/delete when using separate subcommands ([#2398](#2398)) ([b1ea909](b1ea909))
* bump CN to v0.63.9, MN to v0.134, Relay to v0.69.3, BN to v0.14.0, Solo chart to v0.54.5 ([#2322](#2322)) ([e12938f](e12938f))
* bump explorer to v25.1.1 ([#2403](#2403)) ([bfae543](bfae543))
* bump relay version and fix some tests ([#2385](#2385)) ([c2f4bab](c2f4bab))
* correct service name in port-forward command for Mirror Node REST Java API ([#2396](#2396)) ([6847713](6847713))
* do not assign mask value to default value for data sensitive flags ([#2401](#2401)) ([ce96ad9](ce96ad9))
* handle optional adminKey flag safely in context configuration ([#2365](#2365)) ([8b20668](8b20668))
* remove logs of 'argv' and 'context.config' ([#2378](#2378)) ([a4d4e36](a4d4e36))
* remove unnecessary node logs from migration test workflow ([#2400](#2400)) ([43a53fc](43a53fc))
* solo quick-start single deploy failure during network setup ([#2369](#2369)) ([2f12c17](2f12c17))
* update post freeze CN source directory for application.properties ([#2397](#2397)) ([9752f9d](9752f9d))
@swirlds-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Needs Manager Approval A pull request that needs review from a manager. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A new flag to show private key during account creation

4 participants