Merged
Conversation
Contributor
|
Hi @TheCellMC, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
cla-needed
platform: weather.yweather
small-pr
pvizeli
approved these changes
Apr 14, 2018
Member
|
This should have been merged. The mapping of the conditions should stay the same across all |
Member
|
@fabaff you are right. Sorry |
pvizeli
added a commit
that referenced
this pull request
Apr 15, 2018
* Revert "Add unique_id for BMW ConnectedDrive (#13888)" This reverts commit 9014e26. * Revert "Added snips service descriptions (#13883)" This reverts commit 1c4da0c. * Revert "Fix race condition for component loaded before listening (#13887)" This reverts commit bba997e. * Revert "Missing property decorator added (#13889)" This reverts commit bf98b79. * Revert "Update frontend to 20180414.0" This reverts commit 1617fbe. * Revert "Further untangle data entry flow (#13855)" This reverts commit 4d44c0f. * Revert "add support for Kodi discovery (#13790)" This reverts commit 5a5dad6. * Revert "Update yweather.py (#13851)" This reverts commit c3388d6.
Contributor
Author
|
No problem. However, why does yweather have the |
Member
|
Because those kind of changes just sneak in...they don't break things, nobody will recognize it as the frontend will ignore it and the change looks legit at first glance. |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Maped out a few strings for more custom state card possibilities
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: