Add unique_id for BMW ConnectedDrive#13888
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Apr 15, 2018
gerard33:unique-id
Merged
Add unique_id for BMW ConnectedDrive#13888MartinHjelmare merged 2 commits intohome-assistant:devfrom gerard33:unique-id
MartinHjelmare merged 2 commits intohome-assistant:devfrom
gerard33:unique-id
Conversation
homeassistant
added
cla-signed
platform: binary_sensor.bmw_connected_drive
small-pr
Member
|
Can be merged when build passes. |
pvizeli
added a commit
that referenced
this pull request
Apr 15, 2018
* Revert "Add unique_id for BMW ConnectedDrive (#13888)" This reverts commit 9014e26. * Revert "Added snips service descriptions (#13883)" This reverts commit 1c4da0c. * Revert "Fix race condition for component loaded before listening (#13887)" This reverts commit bba997e. * Revert "Missing property decorator added (#13889)" This reverts commit bf98b79. * Revert "Update frontend to 20180414.0" This reverts commit 1617fbe. * Revert "Further untangle data entry flow (#13855)" This reverts commit 4d44c0f. * Revert "add support for Kodi discovery (#13790)" This reverts commit 5a5dad6. * Revert "Update yweather.py (#13851)" This reverts commit c3388d6.
Merged
ghost
added
integration: bmw_connected_drive
and removed
platform: binary_sensor.bmw_connected_drive
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add
unique_idfor the following BMW ConnectedDrive components:The
unique_idis defined as the vin_number plus sensor type as discussed here with @MartinHjelmare.Checklist:
tox. Your PR cannot be merged unless tests pass