Fix race condition for component loaded before listening#13887
Merged
Conversation
homeassistant
added
cla-signed
integration: config
small-pr
MartinHjelmare
approved these changes
Apr 14, 2018
pvizeli
added a commit
that referenced
this pull request
Apr 15, 2018
)" This reverts commit bba997e.
pvizeli
added a commit
that referenced
this pull request
Apr 15, 2018
* Revert "Add unique_id for BMW ConnectedDrive (#13888)" This reverts commit 9014e26. * Revert "Added snips service descriptions (#13883)" This reverts commit 1c4da0c. * Revert "Fix race condition for component loaded before listening (#13887)" This reverts commit bba997e. * Revert "Missing property decorator added (#13889)" This reverts commit bf98b79. * Revert "Update frontend to 20180414.0" This reverts commit 1617fbe. * Revert "Further untangle data entry flow (#13855)" This reverts commit 4d44c0f. * Revert "add support for Kodi discovery (#13790)" This reverts commit 5a5dad6. * Revert "Update yweather.py (#13851)" This reverts commit c3388d6.
balloob
added a commit
that referenced
this pull request
Apr 18, 2018
* Fix race condition for component loaded before listening * async/await syntax
Merged
|
@balloob - any ideas when this fix would be available? I'm on v0.67.0. I'm happy to learn how to look up which fixes will be against what release in github but I'm not sure how to do this. |
|
thanks @riemers - does this imply HA 0.67.1 is ready to upgrade via the "pip3 install --upgrade homeassistant" approach, noting it was only 5 hours ago? |
|
My rule of thumb is, if it is not on the home page it is not yet out. Sometimes it maybe but i don't look at it that straight. Also these conversations are more suited on Discord then in the merged issue :) |
|
ok thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We would miss out on any
component_loadedevents after we checked which components got loaded and before we register a listener (because weyield from)Related issue (if applicable): fixes #13740
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: