fix(ctypes): mismatch between modules field and ctypes stanza#12124
Merged
Alizter merged 2 commits intoocaml:mainfrom Aug 11, 2025
Merged
fix(ctypes): mismatch between modules field and ctypes stanza#12124Alizter merged 2 commits intoocaml:mainfrom
Alizter merged 2 commits intoocaml:mainfrom
Conversation
rgrinberg
requested changes
Aug 10, 2025
Alizter
commented
Aug 10, 2025
rgrinberg
approved these changes
Aug 10, 2025
Alizter
force-pushed
the
gh12018
branch
4 times, most recently
from
00eb0dc to
4cff68e
Compare
When the ctypes stanza asks for some modules, but these are not included in the modules field, we get a code error later during linking. Ideally, these should be caught earlier on and a nice error message presented. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
This was referenced Dec 18, 2025
This was referenced Dec 25, 2025
Alizter
added a commit
that referenced
this pull request
Jan 2, 2026
…3123) This reverts commit 87faddc from #12124. The validation introduced in #12124 is incorrect as explained in #13001. Reproduction case is here #13000. I will merge these separately so it is easier to backport. This PR reverts the PR that introduced the incorrect validation. - #12124 - #13001 - #13000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ctypes stanza asks for some modules, but these are not included
in the modules field, we get a code error later during linking.
We fix this issue by checking for the required modules beforehand and raising a user error if they are missing.
I'm not sure if we need to do something similar for any other generated modules.