Revert "fix(ctypes): add proper user message for missing modules"#13123
Merged
Alizter merged 1 commit intoocaml:mainfrom Jan 2, 2026
Merged
Revert "fix(ctypes): add proper user message for missing modules"#13123Alizter merged 1 commit intoocaml:mainfrom
Alizter merged 1 commit intoocaml:mainfrom
Conversation
Alizter
force-pushed
the
push-ovxsqoxsssrl
branch
from
adfc056 to
79a28a1
Compare
rgrinberg
reviewed
Dec 30, 2025
Alizter
force-pushed
the
push-ovxsqoxsssrl
branch
from
79a28a1 to
19b5a73
Compare
This reverts commit 87faddc. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-ovxsqoxsssrl
branch
from
19b5a73 to
1ee85a5
Compare
rgrinberg
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 87faddc from #12124.
The validation introduced in #12124 is incorrect as explained in #13001. Reproduction case is here #13000. I will merge these separately so it is easier to backport.
This PR reverts the PR that introduced the incorrect validation.