test: ctypes modules field incorrectly validated#13000
test: ctypes modules field incorrectly validated#13000Alizter wants to merge 1 commit intoocaml:mainfrom
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
| > (generated_entry_point C))) | ||
| > EOF | ||
|
|
||
| $ dune build |
There was a problem hiding this comment.
Could you add a plain-text explanation what is expected here and what is failing? That would make it easier to understand the failure case and expected behavior without knowing the entire context.
There was a problem hiding this comment.
The (ctypes (type_description (functor ...))) fields use a module that tells ctypes about the kind of interface to expect for the ffi. Some validation was added to make sure that the module came from the modules of the stanza in #12124. However this assumption is incorrect as there are people using this with this particular interface module coming from a separate location. More information can be found in #13001.
There was a problem hiding this comment.
Yes, but I mean in the cram file. So people reading it can understand what is going on without having to go through the git blame and the github issues.
There was a problem hiding this comment.
I will update the test with explanation, sorry for being unclear.
…3123) This reverts commit 87faddc from #12124. The validation introduced in #12124 is incorrect as explained in #13001. Reproduction case is here #13000. I will merge these separately so it is easier to backport. This PR reverts the PR that introduced the incorrect validation. - #12124 - #13001 - #13000
|
Since we reverted the "fix" there is little point of this test now. |
2 participants
Reproduction case for #13001