Rename global SetTraceProvider and TraceProvider#1102
Merged
MrAlias merged 4 commits intoopen-telemetry:masterfrom Aug 31, 2020
Merged
Rename global SetTraceProvider and TraceProvider#1102MrAlias merged 4 commits intoopen-telemetry:masterfrom
MrAlias merged 4 commits intoopen-telemetry:masterfrom
Conversation
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
======================================
Coverage 77.0% 77.0%
======================================
Files 132 132
Lines 6994 6994
======================================
+ Hits 5389 5390 +1
+ Misses 1361 1359 -2
- Partials 244 245 +1
|
XSAM
approved these changes
Aug 27, 2020
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 28, 2020
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2) - [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102) - [X] Active >1mo - [X] add to CODEOWNERS (done in this pull) - [X] Add to CONTRIBUTING.md (done in this pull) - [X] Maintainer nomination: @MrAlias - [ ] Other maintainer(s) (@Aneurysm9) sign-off - [ ] Add to @open-telemetry/go-approvers
evantorrie
approved these changes
Aug 31, 2020
Contributor
evantorrie
left a comment
evantorrie
left a comment
There was a problem hiding this comment.
Looks fine to me. Just the one question of whether to change the name of the test struct in order to reinforce that these are "tracer" providers, not "trace" providers.
7 tasks
evantorrie
pushed a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
* Rename global {Set,}TraceProvider
Resolves open-telemetry#1101
* Rename unexported and testing vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This naming was in error it should be
TracerProvider.Resolves #1101