Add http content size semantic conventions#905
Merged
MrAlias merged 6 commits intoopen-telemetry:masterfrom Jul 8, 2020
Merged
Add http content size semantic conventions#905MrAlias merged 6 commits intoopen-telemetry:masterfrom
MrAlias merged 6 commits intoopen-telemetry:masterfrom
Conversation
XSAM
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
XSAM
force-pushed
the
feature/http-content-size-conventions
branch
4 times, most recently
from
7bda913 to
8b53c76
Compare
evantorrie
reviewed
Jul 6, 2020
XSAM
force-pushed
the
feature/http-content-size-conventions
branch
from
8b53c76 to
049d690
Compare
jmacd
approved these changes
Jul 7, 2020
Member
Author
|
Since these attribute names already added to the semantic conventions, we should provide the predefined variable to standard package which is convenient for end-user, they can use the variable directly without writing it by hand.
@evantorrie I add |
Aneurysm9
approved these changes
Jul 7, 2020
MrAlias
requested changes
Jul 7, 2020
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
Looks good outside of the const naming.
Signed-off-by: Sam Xie <xsambundy@gmail.com>
Signed-off-by: Sam Xie <xsambundy@gmail.com>
Signed-off-by: Sam Xie <xsambundy@gmail.com>
Signed-off-by: Sam Xie <xsambundy@gmail.com>
Signed-off-by: Sam Xie <xsambundy@gmail.com>
XSAM
force-pushed
the
feature/http-content-size-conventions
branch
from
049d690 to
48105cf
Compare
MrAlias
approved these changes
Jul 8, 2020
Contributor
|
@evantorrie can you open an issue to address integrating these labels to the mentioned instrumentation packages if you think there is more work still? |
Merged
6 tasks
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 28, 2020
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2) - [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102) - [X] Active >1mo - [X] add to CODEOWNERS (done in this pull) - [X] Add to CONTRIBUTING.md (done in this pull) - [X] Maintainer nomination: @MrAlias - [ ] Other maintainer(s) (@Aneurysm9) sign-off - [ ] Add to @open-telemetry/go-approvers
This was referenced Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #890