Add environment variables for Jaeger exporter#796
Merged
MrAlias merged 11 commits intoopen-telemetry:masterfrom Jun 10, 2020
Merged
Add environment variables for Jaeger exporter#796MrAlias merged 11 commits intoopen-telemetry:masterfrom
MrAlias merged 11 commits intoopen-telemetry:masterfrom
Conversation
XSAM
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
Member
Author
|
It looks like |
Member
|
I like the use of |
XSAM
force-pushed
the
feature/jaeger-exporter-env
branch
from
7a7bdf5 to
a2e8905
Compare
Member
Author
|
These options now specified as default options. |
Aneurysm9
approved these changes
Jun 6, 2020
evantorrie
reviewed
Jun 7, 2020
evantorrie
reviewed
Jun 7, 2020
evantorrie
reviewed
Jun 7, 2020
XSAM
force-pushed
the
feature/jaeger-exporter-env
branch
from
53a14cd to
1d58f63
Compare
Member
Author
|
@evantorrie Why has this PR been closed? |
evantorrie
reviewed
Jun 8, 2020
Contributor
Sorry that was a mistake! Let me reopen it. |
jmacd
reviewed
Jun 8, 2020
This was referenced Jun 8, 2020
XSAM
force-pushed
the
feature/jaeger-exporter-env
branch
from
1d58f63 to
5f9f780
Compare
MrAlias
reviewed
Jun 9, 2020
jmacd
approved these changes
Jun 9, 2020
Handle these environment variables: JAEGER_SERVICE_NAME, JAEGER_DISABLED, JAEGER_TAGS, JAEGER_ENDPOINT, JAEGER_USER, JAEGER_PASSWORD
XSAM
force-pushed
the
feature/jaeger-exporter-env
branch
from
5f9f780 to
659aac3
Compare
MrAlias
approved these changes
Jun 10, 2020
6 tasks
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 28, 2020
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2) - [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102) - [X] Active >1mo - [X] add to CODEOWNERS (done in this pull) - [X] Add to CONTRIBUTING.md (done in this pull) - [X] Maintainer nomination: @MrAlias - [ ] Other maintainer(s) (@Aneurysm9) sign-off - [ ] Add to @open-telemetry/go-approvers
This was referenced Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #792
Handle the following environment variables: