Skip to content

fix: windows snapshot for external_agent_config_migration::tests::prompt_snapshot did not match windows output#18915

Merged
bolinfest merged 1 commit intomainfrom
pr18915
Apr 22, 2026
Merged

fix: windows snapshot for external_agent_config_migration::tests::prompt_snapshot did not match windows output#18915
bolinfest merged 1 commit intomainfrom
pr18915

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 22, 2026

Fix a snapshot test that is failing on Windows, but is currently missed by Bazel due to #18913. We see this failing on Cargo builds on Windows, though.

This Bazel vs. Cargo inconsistency explains why #18768 did not fix the Cargo Windows build.

@bolinfest bolinfest requested a review from alexsong-oai April 22, 2026 00:22
@bolinfest bolinfest enabled auto-merge (squash) April 22, 2026 00:23
@bolinfest bolinfest merged commit 6368f50 into main Apr 22, 2026
25 checks passed
@bolinfest bolinfest deleted the pr18915 branch April 22, 2026 00:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants