fix(preview): multiple nested blocks cannot preview #663

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Enhancements
  • Improved handling of block schemas with the introduction of an extra list for asynchronously retrieved schemas.
  • Enhanced panel generation by ensuring accurate naming conventions with the inclusion of the .vue extension in the panel names for blocks.

[coderabbitai]

Walkthrough

The updates to the Preview.vue file enhance the management of block schemas and panel generation. Introduction of an extraList array allows for the asynchronous handling of additional block schemas, while the panelName property now correctly includes the .vue extension. These improvements streamline the component's functionality and improve schema handling efficiency.

Changes

File Path	Summary of Changes
.../Preview.vue	Introduced extraList array for asynchronous block schema handling and updated panelName to include .vue extension.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PreviewComponent
    participant SchemaService

    User->>PreviewComponent: Load Preview
    PreviewComponent->>SchemaService: Fetch initial schemas
    SchemaService-->>PreviewComponent: Return initial schemas
    PreviewComponent->>extraList: Store additional schemas
    PreviewComponent->>SchemaService: Fetch additional schemas asynchronously
    SchemaService-->>PreviewComponent: Return additional schemas
    PreviewComponent->>extraList: Process additional schemas
    PreviewComponent->>User: Display updated panels with correct names

Loading

Poem

In the land of code where changes bloom,
A new array brings schemas to room.
Block names now with .vue, complete,
Asynchronous updates, a treat so sweet.
Panels aligned, in perfect tune,
The Preview shines, beneath the moon. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e651dff and 0646273.

Files selected for processing (1)

• packages/design-core/src/preview/src/preview/Preview.vue (2 hunks)

Additional comments not posted (3)

packages/design-core/src/preview/src/preview/Preview.vue (3)

89-89: Introduction of extraList array.

The extraList array is introduced to store promises for additional block schemas retrieved asynchronously. This helps in processing nested block schemas efficiently.

---

94-99: Processing extraList for nested block schemas.

The extraList array is processed using Promise.allSettled to handle additional block schemas. This ensures that all nested block schemas are retrieved and processed correctly.

---

145-148: Ensure correct panel naming with .vue extension.

The panelName property now includes the .vue extension, ensuring correct panel naming for the blocks.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0646273 and 5541cef.

Files selected for processing (1)

• packages/design-core/src/preview/src/preview/Preview.vue (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/design-core/src/preview/src/preview/Preview.vue